fix(security): harden proxy x-base-url against key leak and SSRF - #6884
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix(security): harden proxy x-base-url against key leak and SSRF#6884BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Inject OPENAI_API_KEY only when the parsed hostname is api.openai.com, and reject private/metadata/loopback targets for the open proxy fallback. Fixes ChatGPTNextWeb#6814 Fixes ChatGPTNextWeb#6813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENAI_API_KEYonly when the parsedx-base-urlhostname is exactlyapi.openai.com(not a query/path/fragment/userinfo substring).x-base-urlvalues and private/metadata/loopback targets (RFC1918, CGNAT, link-local,169.254.169.254,metadata.google.internal, IPv6 loopback/ULA) with HTTP 400 before fetching.Fixes #6814
Fixes #6813
Test plan
./node_modules/.bin/jest --ci test/proxy.test.ts(11 passed)x-base-urlwith?q=api.openai.comno longer receives the server keyx-base-url: http://169.254.169.254returns 400