Skip to content

chore: remove FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS workaround in snapshot tests and update affected snapshots #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sudo-shashank wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore: remove FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS workaround in snapshot tests and update affected snapshots #7154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0aef015
remove workaround
sudo-shashank Jun 9, 2026
6e82e2a
Merge branch 'main' into shashank/fix-test-snapshots
sudo-shashank Jun 11, 2026
9738dab
Merge branch 'main' into shashank/fix-test-snapshots
sudo-shashank Jun 11, 2026
c3d30a0
Update test snapshots
sudo-shashank Jun 11, 2026
282cbe1
Merge branch 'main' into shashank/fix-test-snapshots
sudo-shashank Jun 11, 2026
488ce2a
Merge branch 'main' into shashank/fix-test-snapshots
sudo-shashank Jun 12, 2026
b605317
Merge branch 'main' into shashank/fix-test-snapshots
sudo-shashank Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/state_manager/state_computation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ impl StateManager {
StateRecomputePolicy::Disallowed
};

// https://github.com/ChainSafe/forest/issues/7118
#[cfg(test)]
let policy = {
_ = policy;
StateRecomputePolicy::Allowed
};

self.load_executed_tipset_with_cache(ts, policy).await
}

Expand Down
5 changes: 3 additions & 2 deletions src/tool/subcommands/api_cmd/api_compare_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,10 +1673,11 @@ fn eth_tests_with_tipset<DB: Blockstore + ShallowClone>(
EthGetBlockReceipts::request((Predefined::Latest.into(),))?.with_api_path(api_path),
),
RpcTest::basic(
EthGetBlockReceipts::request((Predefined::Latest.into(),))?.with_api_path(api_path),
EthGetBlockReceipts::request((Predefined::Safe.into(),))?.with_api_path(api_path),
),
RpcTest::basic(
EthGetBlockReceipts::request((Predefined::Latest.into(),))?.with_api_path(api_path),
EthGetBlockReceipts::request((Predefined::Finalized.into(),))?
.with_api_path(api_path),
),
RpcTest::identity(
EthGetBlockReceipts::request((BlockNumberOrHash::from_block_hash_object(
Expand Down
28 changes: 13 additions & 15 deletions src/tool/subcommands/api_cmd/test_snapshots.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,22 @@ filecoin_ethcall_v2_1765790311230200.rpcsnap.json.zst
filecoin_ethcall_v2_1765790311230270.rpcsnap.json.zst
filecoin_ethcall_v2_1765790311230334.rpcsnap.json.zst
filecoin_ethchainid_1736937942819147.rpcsnap.json.zst
filecoin_ethfeehistory_1737446676883828.rpcsnap.json.zst
filecoin_ethfeehistory_v2_1767605175056660.rpcsnap.json.zst
filecoin_ethfeehistory_1781166099973654.rpcsnap.json.zst
filecoin_ethfeehistory_v2_1781166099990041.rpcsnap.json.zst
filecoin_ethgasprice_1758725940980141.rpcsnap.json.zst
filecoin_ethgetbalance_1773156637422018.rpcsnap.json.zst
filecoin_ethgetbalance_v1_unknown_addr_1770287845559622.rpcsnap.json.zst
filecoin_ethgetbalance_v2_latest_1770291948779489.rpcsnap.json.zst
filecoin_ethgetbalance_v2_pending_1770291949065157.rpcsnap.json.zst
filecoin_ethgetbalance_v2_safe_1770291948803158.rpcsnap.json.zst
filecoin_ethgetbalance_v2_unknown_addr_1770287845559744.rpcsnap.json.zst
filecoin_ethgetblockbyhash_1773157415768830.rpcsnap.json.zst
filecoin_ethgetblockbyhash_1781166100013912.rpcsnap.json.zst
filecoin_ethgetblockbynumber_1737446676696328.rpcsnap.json.zst
filecoin_ethgetblockbynumber_v2_1768192171057588.rpcsnap.json.zst
filecoin_ethgetblockreceipts_1773157886472662.rpcsnap.json.zst
filecoin_ethgetblockreceipts_v2_1773157886472662.rpcsnap.json.zst
filecoin_ethgetblockreceipts_v2_finalized_1769603486031510.rpcsnap.json.zst
filecoin_ethgetblockreceipts_v2_safe_1769603485649367.rpcsnap.json.zst
filecoin_ethgetblockreceiptslimited_1773157887312363.rpcsnap.json.zst
filecoin_ethgetblockreceiptslimited_v2_1773157887312363.rpcsnap.json.zst
filecoin_ethgetblockbynumber_v2_1781166100024105.rpcsnap.json.zst
filecoin_ethgetblockreceipts_1781166100049979.rpcsnap.json.zst
filecoin_ethgetblockreceipts_v2_1781166100038659.rpcsnap.json.zst
filecoin_ethgetblockreceiptslimited_1781166100061549.rpcsnap.json.zst
filecoin_ethgetblockreceiptslimited_v2_1781166100066779.rpcsnap.json.zst
filecoin_ethgetblocktransactioncountbyhash_1773159049678664.rpcsnap.json.zst
filecoin_ethgetblocktransactioncountbynumber_1737446676697272.rpcsnap.json.zst
filecoin_ethgetblocktransactioncountbynumber_v2_1769099953133906.rpcsnap.json.zst
Expand All @@ -88,7 +86,7 @@ filecoin_ethgetcode_v2_1769605928230413.rpcsnap.json.zst
filecoin_ethgetcode_v2_finalized_1769605928335700.rpcsnap.json.zst
filecoin_ethgetcode_v2_safe_1769605928230488.rpcsnap.json.zst
filecoin_ethgetcode_v2_unknown_addr_1770288914644057.rpcsnap.json.zst
filecoin_ethgetlogs_1759922913569082.rpcsnap.json.zst
filecoin_ethgetlogs_1781166100077939.rpcsnap.json.zst
filecoin_ethgetmessagecidbytransactionhash_1737446676697418.rpcsnap.json.zst
filecoin_ethgetstorageat_1765803742043605.rpcsnap.json.zst # latest
filecoin_ethgetstorageat_1765803742046844.rpcsnap.json.zst # concrete
Expand All @@ -112,9 +110,9 @@ filecoin_ethgettransactioncount_v1_unknown_addr_1770288294132251.rpcsnap.json.zs
filecoin_ethgettransactioncount_v2_1776080971678636.rpcsnap.json.zst
filecoin_ethgettransactioncount_v2_unknown_addr_1770288294132366.rpcsnap.json.zst
filecoin_ethgettransactionhashbycid_1737446676698540.rpcsnap.json.zst
filecoin_ethgettransactionreceipt_1741272955712904.rpcsnap.json.zst
filecoin_ethgettransactionreceipt_1765811578590165.rpcsnap.json.zst # transaction not found
filecoin_ethgettransactionreceiptlimited_1741272955611272.rpcsnap.json.zst
filecoin_ethgettransactionreceipt_1781166100130434.rpcsnap.json.zst
filecoin_ethgettransactionreceiptlimited_1781166100143680.rpcsnap.json.zst
filecoin_ethmaxpriorityfeepergas_1758727346451988.rpcsnap.json.zst
filecoin_ethnewblockfilter_1741779995902203.rpcsnap.json.zst
filecoin_ethnewfilter_1741781607617949.rpcsnap.json.zst
Expand All @@ -126,8 +124,8 @@ filecoin_ethtraceblock_1778490939373124.rpcsnap.json.zst
filecoin_ethtraceblock_1778490939373993.rpcsnap.json.zst
filecoin_ethtracefilter_1778490960729591.rpcsnap.json.zst
filecoin_ethtracefilter_1778490960732604.rpcsnap.json.zst
filecoin_ethtracefilter_1778490960890609.rpcsnap.json.zst
filecoin_ethtracefilter_1778490960890755.rpcsnap.json.zst
filecoin_ethtracefilter_1781166100341197.rpcsnap.json.zst
filecoin_ethtracereplayblocktransactions_1768898971081023.rpcsnap.json.zst
filecoin_ethtracereplayblocktransactions_1768898971153948.rpcsnap.json.zst
filecoin_ethtracetransaction_1778495993884978.rpcsnap.json.zst
Expand All @@ -149,7 +147,7 @@ filecoin_filecoinaddresstoethaddress_1771946498262483.rpcsnap.json.zst # latest
filecoin_filecoinaddresstoethaddress_1771946498262885.rpcsnap.json.zst # safe tag
filecoin_gasestimategaslimit_1741782110512299.rpcsnap.json.zst
filecoin_gasestimatemessagegas_1758735195199472.rpcsnap.json.zst
filecoin_getactoreventsraw_1741782590255476.rpcsnap.json.zst
filecoin_getactoreventsraw_1781166100457754.rpcsnap.json.zst
filecoin_market_addbalance_statedecodeparams_1757426002278914.rpcsnap.json.zst
filecoin_market_addbalanceexported_statedecodeparams_1757426002338931.rpcsnap.json.zst
filecoin_market_constructor_statedecodeparams_1757426002270973.rpcsnap.json.zst
Expand Down
Loading