feat(dev): add missing snapshots checker#6736
Merged
LesnyRumcajs merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
LesnyRumcajs
requested review from
akaladarshi and
hanabi1224
and removed request for
a team
Contributor
WalkthroughIntroduces a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
hanabi1224
approved these changes
Mar 13, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/dev/subcommands/archive_missing_cmd.rs (1)
54-59: Consider usingexpect()instead ofunwrap()for consistency with coding guidelines.While this regex pattern is a compile-time constant that will always succeed, using
expect()with a descriptive message is preferred per the project's coding guidelines.Suggested change
fn extract_height(url: &Url) -> Option<ChainEpoch> { - static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"_height_(\d+)").unwrap()); + static RE: LazyLock<Regex> = + LazyLock::new(|| Regex::new(r"_height_(\d+)").expect("valid regex pattern")); let path = url.path(); let caps = RE.captures(path)?; caps[1].parse().ok() }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/dev/subcommands/archive_missing_cmd.rs` around lines 54 - 59, The regex uses Regex::new(...).unwrap() in extract_height which violates the guideline; replace the unwrap() with expect(...) supplying a short descriptive message (e.g., "invalid regex in extract_height") when initializing the static RE so the Regex::new call still panics on programmer error but with a clear message; keep the rest of extract_height (path, captures, parse) unchanged and reference the static RE and function extract_height when applying the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/dev/subcommands/archive_missing_cmd.rs`:
- Around line 54-59: The regex uses Regex::new(...).unwrap() in extract_height
which violates the guideline; replace the unwrap() with expect(...) supplying a
short descriptive message (e.g., "invalid regex in extract_height") when
initializing the static RE so the Regex::new call still panics on programmer
error but with a clear message; keep the rest of extract_height (path, captures,
parse) unchanged and reference the static RE and function extract_height when
applying the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 52bf56a5-b4a5-4912-a9e4-1b5433f8c7fb
📒 Files selected for processing (2)
src/dev/subcommands/archive_missing_cmd.rssrc/dev/subcommands/mod.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features