ci: bump docker actions to node24, fix go module cache path in release.yml - #21
Merged
Merged
Conversation
…e.yml Fixes the 5 remaining annotations on the release workflow run: - docker/login-action v3 -> v4 and docker/build-push-action v5 -> v7 (both now declare using: node24; v6 of build-push-action was still node20) - setup-go's default cache lookup expects go.mod/go.sum at the repo root, but this repo's Go module lives in go/. Added the same cache-dependency-path: go/go.sum already used in ci.yml to the two setup-go steps in release.yml that were missing it, fixing the 'Restore cache failed: Dependencies file is not found' annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
5 annotations remained on the release workflow after #20 (https://github.com/ChainSafe/docker-socket-policy/actions/runs/32172569093):
Node.js 20 is deprecated ... docker/build-push-action@v5, docker/login-action@v3(3x — one per language job: go, rust, ts)Restore cache failed: Dependencies file is not found in .../docker-socket-policy. Supported file pattern: go.mod(2x — release-verify and release-go jobs)Fix
docker/login-actionv3 → v4 anddocker/build-push-actionv5 → v7 (v6 still targets node20; v7 is the first to declareusing: node24). No relevant breaking changes for our usage (noDOCKER_BUILD_NO_SUMMARY/DOCKER_BUILD_EXPORT_RETENTION_DAYSenvs used).release.ymlhas twoactions/setup-go@v7steps that never gotcache-dependency-path: go/go.sum(unlike the equivalent step inci.yml, fixed in ci: bump actions/checkout, setup-go, setup-node to latest majors #20's predecessor work). Since this repo's Go module lives ingo/not the repo root, setup-go's default cache lookup fails. Added the missing input to both steps.Verification
Will confirm via this PR's own
release-verify/gojob runs that the annotations are gone, plus the next real release run after merge.