Skip to content

fix(speedtest): fail-open prefill check #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Sep 4, 2026
Merged

fix(speedtest): fail-open prefill check #2255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/components/speedtest/speedtest-rpc-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,21 @@ export function SpeedtestRpcClient() {
if (prefillEpoch.current !== epoch) return; // user picked again
const good = checks.filter((x) => x.ok).map((x) => x.e.url);
const skipped = checks.filter((x) => !x.ok).map((x) => x.e.provider);
if (skipped.length > 0) setInputs(good.length > 0 ? good : [""]);
// FAIL-OPEN: when every endpoint flunks the quick check, the
// blocker is almost certainly environmental (VPN, shields, a
// privacy extension, captive portal), not five independent CORS
// failures. Keep the full list and let the real test classify;
// only drop endpoints when the signal is differential (some pass,
// some fail).
if (good.length === 0) {
setSkippedProviders([]);
setPrefillState("done");
console.warn(
"[speedtest] reachability precheck failed for ALL endpoints; keeping the list (likely browser/network-level blocking).",
);
return;
}
if (skipped.length > 0) setInputs(good);
setSkippedProviders(skipped);
setPrefillState("done");
})();
Expand Down
Loading