Skip to content

fix(app-store-ratings): last_over_time[31m] on reviews panel for 7d+ staleness - #2070

Open
Flotapponnier wants to merge 5 commits into
devfrom
fix/hl-main
Open

fix(app-store-ratings): last_over_time[31m] on reviews panel for 7d+ staleness#2070
Flotapponnier wants to merge 5 commits into
devfrom
fix/hl-main

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Summary

  • app_store_reviews_total is scraped every 30 min; Prometheus default lookback is 5 min
  • For 7d/30d query_range with 2h step, ~5/6 of grid points fall outside the lookback window → denseSeriesFromMatrix returns null → 404 → "no data" in UI
  • Fix: wrap panel metric in last_over_time(…[31m]) so each step looks back up to 31 min, guaranteeing a sample per scrape cycle
  • 24h view was unaffected (served from materialized blob, not live Prom)

Test plan

  • ?view=reviews on 7d / 30d should now render the review-count series for all 11 providers
  • 24h view unchanged

* feat: HL vs Gains wallet fee comparison tool

* feat: HL vs Gains wallet fee comparison

* fix: fetch Gains fee rates live, drop hardcoded 0.12%

* fix: fetch Gains fee rates live, drop hardcoded rates

* feat: HL vs Gains wallet fee comparison tool

* fix: fetch Gains fee rates live, drop hardcoded 0.12%

* feat: per-trade table, live Gains rates per coin, PnL column

* fix: remove duplicate gainsFeeCache declaration

* feat: fee-compare per-trade breakdown + live Gains rates

* feat: HL vs Gains wallet fee comparison tool

* fix: fetch Gains fee rates live, drop hardcoded 0.12%

* feat: per-trade table, live Gains rates per coin, PnL column

* fix: remove duplicate gainsFeeCache declaration

* redesign: fee-compare UI — logos, VS card, trade table, per-fill savings (#2046)

* perf: reduce Vercel invocations - live-prices 1s->5s CDN TTL, alternatives+perp ISR 300s

* fix: double-counted notional in HL vs Gains comparison (#2048)

* redesign: fee-compare UI — logos, VS card, trade table, per-fill savings

* fix: double-counted notional in HL vs Gains comparison — use per-side rate

* fix: rename Gains.trade -> Gains, HL -> Hyperliquid in UI (#2049)

* feat: always show Gains simulated, bold winner, pro design (#2051)

* fix: mobile responsive — stack VS card vertically, hide overflow columns (#2052)

* fix: symmetric HL/Gains display + winner logic for single-platform wallets (#2053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant