Fix input_dim and out_dim Not getting saved in model checkpoint#97
Merged
sfluegel05 merged 3 commits intodevfrom Jul 14, 2025
Merged
Fix input_dim and out_dim Not getting saved in model checkpoint#97sfluegel05 merged 3 commits intodevfrom
input_dim and out_dim Not getting saved in model checkpoint#97sfluegel05 merged 3 commits intodevfrom
Conversation
Collaborator
|
After merging the dev branch (which passes the unittests) into this branch (which also passes the unittests), the tests suddenly fail with the same error as in #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Summary of the Issue
When using
LightningCLI, we pass--model.input_dimand--model.out_dimimplicitly viaparser.link_arguments()(e.g. linking fromdata.feature_vector_sizeanddata.num_of_labels).However, these values appear as
nullin the generatedmodel_checkpoint.ckptfile, even though they are correctly assigned at runtime.🔍 Root Cause
This is due to the fact that:
As a result, any parameters set via
parser.link_arguments(...)(such asinput_dim,out_dim, etc.) are not yet populated when the configuration is saved — leading to them showing up asnullin hparams.✅ What This PR Does
input_dimandout_dimtoself.hparamsto ensure they are captured at runtime, even if linked.