Add table cell background color#231
Open
botzill wants to merge 3 commits intoCenterForOpenScience:masterfrom
Open
Add table cell background color#231botzill wants to merge 3 commits intoCenterForOpenScience:masterfrom
botzill wants to merge 3 commits intoCenterForOpenScience:masterfrom
Conversation
Contributor
Author
|
@winhamwr Any chance you can take a look at this PR as well ? |
botzill
force-pushed
the
issue-230-table-cell-background-color
branch
from
79ed846 to
4cf6299
Compare
jhubert
reviewed
Feb 23, 2017
| background_fill = getattr(self, 'background_fill', None) | ||
|
|
||
| # There is no need to set white background color | ||
| if background_fill not in ('auto', 'FFFFFF'): |
Contributor
There was a problem hiding this comment.
Does it make sense to reuse COLOR_FOR_DARK_BACKGROUND here?
Contributor
Author
There was a problem hiding this comment.
I guess we can use, word color is also in RRGGBB format, good catch 👍 .
botzill
force-pushed
the
issue-230-table-cell-background-color
branch
2 times, most recently
from
aa503bf to
2bf9a7b
Compare
botzill
force-pushed
the
issue-230-table-cell-background-color
branch
from
2bf9a7b to
fd31f4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #230.
Few notes about implementation. Currently we may have cases when cell background color is set to a dark color(like black). In Office this is handled automatically and they convert text into white(if there is not custom color set for text). I also tried to handle this case by checking the color brightness using this formula: http://alienryderflex.com/hsp.html. This way if we detect a dark color we convert text to custom white color.