Skip to content

Fix XSS vulnerability and improve error handling in manifest-import component #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cubap merged 2 commits into from
Feb 2, 2026
Merged

Fix XSS vulnerability and improve error handling in manifest-import component #414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ddd61
Initial plan
Copilot Feb 2, 2026
6e39534
Fix security and code quality issues in manifest-import component
Copilot Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions components/manifest-import/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

import TPEN from '../../api/TPEN.js'
import { getUserFromToken } from '../iiif-tools/index.js'
import { escapeHtml } from '/js/utils.js'

class ManifestImport extends HTMLElement {
Expand All @@ -26,6 +25,11 @@ class ManifestImport extends HTMLElement {
this.load()
}

disconnectedCallback() {
// Cleanup - component uses innerHTML replacement for rendering,
// so no manual event listener cleanup needed
}

async load() {
this.#authToken = TPEN.getAuthorization()
if (!this.#authToken) {
Expand Down Expand Up @@ -89,8 +93,14 @@ class ManifestImport extends HTMLElement {
})

if (!response.ok) {
const errorData = await response.json()
throw new Error(errorData.message || `HTTP ${response.status}`)
let errorMessage = `HTTP ${response.status}`
try {
const errorData = await response.json()
errorMessage = errorData.message || errorMessage
} catch {
// Response was not JSON - use HTTP status
}
throw new Error(errorMessage)
}

return response.json()
Expand Down Expand Up @@ -536,8 +546,8 @@ class ManifestImport extends HTMLElement {
</div>
${failed.map(error => `
<div class="error-item">
<strong>${error.message}</strong>
<div class="error-url">${error.manifestUrl}</div>
<strong>${escapeHtml(error.message || '')}</strong>
<div class="error-url">${escapeHtml(error.manifestUrl || '')}</div>
</div>
`).join('')}
</div>
Expand Down