PAINTROID-737: Add Pipette Tool

[bhav-khurana]

Ticket

PAINTROID 737

New Features and Enhancements

As present in the native application, a pipette tool for selecting a particular color from the current state of the drawing canvas is implemented. This tool is a part of the colorpicker package itself and allows the user to pick any color from the drawing and use it on other objects.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Add the link to the ticket in Jira in the description of the PR
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Make sure to organize imports with 'make sort' before committing
• Confirm that the changes follow the project’s coding guidelines (Wiki)
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
• Confirm that new and existing tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Add new information to the Wiki

[bhav-khurana]

Hi @juliajulie95 @msesko @bakicelebi
I have implemented the pipette tool but there is one issue I'm facing that whenever I click on a color in the pipette tool screen and reuse it, it does not match exactly the one that is on the drawing canvas. I am not able to figure out if anything is missing/wrong in the code. Can you please help me out in finding out where exactly the bug might be occurring?

[bakicelebi]

Hi Bhav, I could not reproduce the problem you are having. But i found another similar issue. Transparent colors while drawing are darker. Only after onUp when the command is executed the transparency is correct. And the problem you are describing is happening only when the colors are transparent. I am guessing there is an underlying issue with the color picker and not the pipette tool itself. I will have to have a deeper look but for now few suggestions:

1. Opening a page should be not necessary. We should keep the same flow as native version of the app. (Instantly selecting the color under the finger)
2. Enable ModalBottomSheet pipette tool it still defaults to brush tool
3. This is more of an color picker issue but with my specific emulator (small screen size) the apply button is not visible and is very hard to scroll down

[bhav-khurana]

This is more of an color picker issue but with my specific emulator (small screen size) the apply button is not visible and is very hard to scroll down

For this, should I enable scrolling so that the apply button becomes visible? or reduce the size of each component

[bakicelebi]

This is more of an color picker issue but with my specific emulator (small screen size) the apply button is not visible and is very hard to scroll down

For this, should I enable scrolling so that the apply button becomes visible? or reduce the size of each component

It is already scrollable but it is really hard. I think this can be fixed in color picker PR. Imo we can do bit compacter dynamic design so that the scrolling of bottomsheet is never activated.

[Lenkomotive]

pls fix conflicts

[bhav-khurana]

@Lenkomotive fixed conflicts

[bakicelebi]

Opening a new page for pipette tool is overkill. As mentioned in my previous comment the kotlin version of Pocket Paint doesnt open a new page. You can approach this tool the easiet way:

1. onTap -> get color of the pixel under the point
2. set paint color to that color using paint provider

This simplyfies the user experience and matches the original implementation of the tool and removes alot of unnessary code.

[juliajulie95]

@bhav-khurana Hi, are you still working on this or should someone take over?