Skip to content

Fix pagination visibility handling on media library overview page#6156

Merged
dmetzner merged 1 commit intoCatrobat:developfrom
Aaditya0411:fix-media-library-overview-ui
Feb 12, 2026
Merged

Fix pagination visibility handling on media library overview page#6156
dmetzner merged 1 commit intoCatrobat:developfrom
Aaditya0411:fix-media-library-overview-ui

Conversation

@Aaditya0411
Copy link
Copy Markdown
Contributor

Description

Fixes an issue where the pagination container visibility was accessed
without checking if the element exists on the media library overview page.

Changes

  • Added a null-check before modifying pagination container visibility
  • Prevents potential JavaScript runtime errors and UI inconsistencies

Fixes #6154

@Aaditya0411 Aaditya0411 requested a review from dmetzner as a code owner February 1, 2026 07:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.94%. Comparing base (8a585eb) to head (39db9f0).
⚠️ Report is 42 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6156   +/-   ##
==========================================
  Coverage      51.94%   51.94%           
  Complexity      7964     7964           
==========================================
  Files            733      733           
  Lines          25569    25569           
==========================================
  Hits           13282    13282           
  Misses         12287    12287           
Flag Coverage Δ
behat 49.70% <ø> (ø)
phpunit 10.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aaditya0411
Copy link
Copy Markdown
Contributor Author

Aaditya0411 commented Feb 9, 2026

Hi Maintainers

It looks like the failing Behat test (api-projects search) might be unrelated to this frontend pagination change.
Could you please confirm whether this failure is expected, or if I should rebase the branch with the latest develop?

I’m happy to update the PR as needed. Thanks for your time and review!

@dmetzner dmetzner merged commit 335144b into Catrobat:develop Feb 12, 2026
46 of 47 checks passed
@Aaditya0411 Aaditya0411 deleted the fix-media-library-overview-ui branch February 13, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor JavaScript UI improvement on project page

2 participants