You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for engaging @zbynek - I can see that the other requests have been open a while, is it basically just held up with the maintainer(s)?
I also had the thought that perhaps a -napi fork of windows-registry should be published to the registry so that users might choose between the NAPI enabled version and this one depending on their node versions, but it seems like fixing this one and making it backward compatible with currently support node versions seems to make the most sense. Thoughts?
If there's interest, I did end up writing an NAPI package native-reg after opening #62, but be warned it has an incompatible C-style API at the moment, so it's not drop-in. I'm happy to take requests, including API changes though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for node 12 support and this seemed to work so I thought I would file a PR to see if you think it should go into the main repo.