Old Border Shandalar: Add rotating Adventure battle backgrounds - #11392
Old Border Shandalar: Add rotating Adventure battle backgrounds#11392vanja-ivancevic wants to merge 4 commits into
Conversation
1a5bae4 to
6e648c0
Compare
|
I agree. If other modders want to add backgrounds, the bloat will continue
to increase. Additionally, this is 20MB of data that vanilla Shandalar
players won't even use.
One approach could be making it optional in the settings via an
auto-download feature, handling backgrounds similarly to how we handle card
art, like hosting them separately for users to download.
Personally, I would like to have them activated by default for Old Border
Shandalar, as it enhances the experience. Perhaps when a user switches to
and loads that specific adventure mode, the assets could download in the
background. Most users likely wouldn't mind an extra 20MB of cached art,
especially since we already cache card art this way.
Maybe we can have the game download all images in given folders on a
server, that way modders can add/remove bgs without updates too…
Do you have any preferences?
…On Sat, Jul 25, 2026 at 23:54 tool4ever ***@***.***> wrote:
***@***.**** commented on this pull request.
I like the idea, though this adds yet another 20MB of extra assets to
download for every user
Since these seem rather optional imo it's time to think about how they can
be downloaded manually like some of the other parts
—
Reply to this email directly, view it on GitHub
<#11392?email_source=notifications&email_token=ANP6R237OOKGXQLKNDUJEA35GUT7VA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZYGAZDOMJTG43KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4780271376>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANP6R27Z5SEK463JWVLPI4T5GUT7VAVCNFSNUABFKJSXA33TNF2G64TZHM2DOOJYHEYDENZSHNEXG43VMU5TIOJXG43TAMBQGU42C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Well some of the lists for the ingame downloaders already point at your domain anyway |
6e648c0 to
4d71117
Compare
|
This is cool, and I would definitely use this feature. If you did package it into the new tabs interface I'm proposing, display would be a logical place to stick it, since there are other settings there that are similar, as tool4forever pointed out. The tabs definitely become more useful as more GUI options get added, as I'm finding with the additional enhancements I'm doing on local that I haven't pushed upstream until there's more discussion about some of the existing pending changes. More of an advanced feature, but it would also be neat if plane authors could assign (and distribute) background overrides for specific combat encounters or creature archetypes (if this doesn't already exist). |
|
Jetz72
left a comment
There was a problem hiding this comment.
Still iffy about third party content URLs for assets being included in the main repo. It's not unprecedented, but it's also not unprecedented that such a site proves unsustainable. Ideally we could someday shift to a system where entire Adventure planes can easily be downloaded and installed as complete packages, and then there's no risk of the user getting an incomplete experience. But for now I think this implementation is alright, pending confirmation on iOS handling.
| String adventureCacheDirectory = GuiBase.getAdventureCacheDirectory(); | ||
| if (adventureCacheDirectory != null && !adventureCacheDirectory.isEmpty()) { | ||
| FileHandle cachedFile = Gdx.files.absolute(adventureCacheDirectory + ForgeConstants.SKIN_DIR + filename); | ||
| if (cachedFile.exists()) { | ||
| return cachedFile; | ||
| } | ||
| } |
There was a problem hiding this comment.
@shoeless Will this work with the new iOS support? I saw in that PR that several instances of Gdx.files.absolute got swapped out.
skin/battle-backgrounds.txtinto the selected plane's cache without adding a user setting.battleBackgroundfolder overrides for reusable enemy definitions, individual enemies placed in TMX maps, and points of interest.