Improve lobby sleeve icon downscaling#10952
Open
MostCromulent wants to merge 1 commit into
Open
Conversation
The lobby panel drew the full 360x500 sleeve source straight into a 58x80 label, a ~6x single-pass reduction that looked aliased and rough. Route the three icon-set sites through a helper that pre-scales once via the cached area-averaging resize() at 2x the label size, leaving HiDPI headroom. The scaled image is cached per sleeve, so the heavy downscale runs once rather than on every repaint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tool4ever
requested changes
Jun 11, 2026
tool4ever
left a comment
tool4ever
left a comment
Contributor
There was a problem hiding this comment.
This seems wrong since FLabel already has some own logic for it:
maybe the current iconScaleFactor would be a better approach?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor polish for #10929
The lobby panel drew the full 360x500 sleeve source straight into a 58x80 label, a ~6x single-pass reduction that looked aliased and rough. Instead, scale via area-averaging resize() at 2x the label size. This looks much smoother at small icon size and avoids aliasing.
The scaled image is cached so the downscale runs once rather than on every repaint.
🤖 Generated with Claude Code