Add scryfall_uuid extra-params to edition files#10938
Closed
phughk wants to merge 1 commit into
Closed
Conversation
phughk
force-pushed
the
fix-10413-edition-uuid-data
branch
from
f6a901a to
2e401af
Compare
tehdiplomat
requested changes
Jun 9, 2026
tehdiplomat
left a comment
tehdiplomat
left a comment
Contributor
There was a problem hiding this comment.
I'll have comments later, just want to make sure this doesn't get merged for now
phughk
force-pushed
the
fix-10413-edition-uuid-data
branch
from
2e401af to
6eec563
Compare
UUIDs stored in forge-gui/res/cdn_uuid/{scryfallCode}/{collectorNumber}.json.
Each file maps all available language codes to the CDN UUID for that print:
{"de":"...","en":"...","es":"...","fr":"...","ja":"...","ko":"...","pt":"...","ru":"...","zhs":"...","zht":"..."}
Generated from Scryfall all_cards bulk export (all languages, all prints).
115,230 collector-number files across 1,041 sets; 62,559 with multiple
language entries.
Included with the assets zip. Optional for users — those who do not update
assets fall back to the rate-limited Scryfall API or cardforge server.
To regenerate after a Scryfall data update:
java -jar forge-scryfall-uuid-map.jar --output-dir forge-gui/res/cdn_uuid
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
phughk
force-pushed
the
fix-10413-edition-uuid-data
branch
from
6eec563 to
b39d24d
Compare
Contributor
Author
|
Closing and moving to forge extras |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #10928 (the runtime CDN fetcher) needs a UUID for each card to construct non-rate-limited CDN URLs. Those UUIDs must be bundled with the game so they are available offline and without any API calls at startup.
What this PR contains
115,230 small JSON files under
forge-gui/res/cdn_uuid/:Each file maps language codes to the Scryfall UUID for that printing. DFCs store
[frontUuid, backUuid]when the faces differ.How it was generated
Using the CLI tool from PR #10937 against Scryfall's
default-cardsbulk-data snapshot.Size note
The files are plain JSON, typically ~100–300 bytes each. Total uncompressed ~20 MB; they compress well and are included in the existing
res/directory that ships with every Forge distribution.Depends on
PR #10928 — the runtime code that reads these files. Without it, the files are inert.