Fix macro replay after auto-yield input flow changes#10930
Open
Madwand99 wants to merge 5 commits into
Open
Conversation
tool4ever
reviewed
Jun 10, 2026
Contributor
|
I'm not convinced trying to solve this with somewhat convoluted heuristics is a good direction: |
Contributor
Author
|
I've changed the PR to suppress auto-yield behavior during recording/replay. This just leaves the numerous miscellaneous improvements to replay handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates macro replay to work with the newer input flow introduced around auto-yield changes in #10606.
After those changes, the macro system could no longer assume that recorded actions would be replayed against the same simple prompt sequence as before. In practice, replay could stall or drift when prompts appeared between recorded actions, especially around:
Without adapting to those input-flow changes, recorded macros can fail even when the original sequence is still legal and repeatable.
The main change is that replay now treats recorded actions as choices that may need to wait for, skip past, or satisfy the current GUI input prompt.
RecordActionsMacroSystemkeeps the macro sequencing/retry logic, whileMacroActionReplayerhandles GUI-specific replay of individual recorded actions against the currentInputtype.This work was split off from the Macro Window UI work (#10746) so the replay compatibility fixes can be reviewed on their own.