Repository navigation
fix(web): Infra ledger stays readable at 768 and 1024 px - #4203
Merged
Merged
Conversation
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

At 768 px and 1024 px the Billing ledger's Type column shrank to about 70 px. Its label ran over the Reference column and each note wrapped one word per line. The Type cell was
w-full max-w-0with a label that never wraps, and the Reference column now holds "Video 4te2..." style references, wider than the row ids it showed before.What changed (
credit-transaction-table.tsxonly)w-full min-w-[140px] whitespace-normal, so the label wraps inside its own column and notes wrap at a readable width.xlbreakpoint the Reference cell stacks the kind ("Video", "Transcript") above the id and caps it at 124 px, with long ids truncated and the full value in the hover title. Fromxlup it is one line capped at 220 px, as before.md) and the phone card list are unchanged.Proof
Rendered on a separate machine from a local bundle of the real component inside the real
Blockcard, at the card widths production uses at each viewport (measured read-only on cap.so), with a 25-row ledger of the same shape as a production app.The bundle's main build gives the same column widths as production at 768 and 1024 px (170, 66, 245, 95, 71), so it renders like the live page.
min-w-[140px]andwhitespace-normaland nomax-w-0; the Reference cell's narrow andxlclasses; the phone card reference stays inline.organization-settings-ownership.test.tserror.Scope and captures
apps/web/app/(infra)/dashboard/infra/_components/credit-transaction-table.tsxand its unit test,apps/web/__tests__/unit/infra-ledger-reference-column.test.ts.!whitespace-normal, because the sharedTDclass carrieswhitespace-nowrapand would otherwise win. Re-rendered with the longest real labels ("Storage, first month, part paid", "Storage, first month, unpaid", "Auto top-up declined", "Payment disputed"): at 768 and 1024 px they wrap inside the 162 to 166 px Type column with no overlap, and Amount and Balance stay in the card.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Makes the billing ledger easier to read at tablet widths.
Reviews (3) · Last reviewed commit: "fix(web): make the ledger Type label wra..." · Reviewed by Greptile