Repository navigation
fix(timestamp): eliminate f64 timebase drift and mantissa truncation in long recordings (#2144) - #3936
Open
frds3445 wants to merge 3 commits into
Open
fix(timestamp): eliminate f64 timebase drift and mantissa truncation in long recordings (#2144)#3936frds3445 wants to merge 3 commits into
frds3445 wants to merge 3 commits into
Conversation
…dings Replace f64 timebase division and u64-to-f64 epoch casts in MachAbsoluteTimestamp and PerformanceCounterTimestamp with 128-bit integer rational arithmetic so cursor and video timelines remain synchronized across multi-hour recordings. Fixes CapSoftware#2144 Signed-off-by: Lucas Oliveira <kalopsia3445@gmail.com>
Contributor
|
@frds3445 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ross high uptimes
…d Windows Use a base timestamp above 2^53 with the low bit set in macos.rs and win.rs tests and cover Add/Sub/AddAssign/SubAssign operator roundtrips.
Member
|
Thanks @frds3445, this looks like a useful change. Before we can merge it:
Once that's sorted, request a re-review from Greptile. |
Author
|
Thanks @richiemcilroy, re-ran Greptile on the latest commit (3baf109) and it is at 5/5 now. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates cumulative
f64timebase drift between cursor telemetry and video frames during long recordings (#2144):u128/i128) arithmetic anchored to a shared monotonic recording epoch before converting to rational media timestamps, preventing floating-point mantissa truncation over multi-hour sessions.Fixes #2144
/claim #2144
The PR appears safe to merge; no blocking issues remain.Summary
The PR replaces floating-point timestamp conversions with integer math on macOS and Windows.
Reviews (2) · Last reviewed commit: "test(timestamp): assert >2^53 tick and o..." · Reviewed by Greptile