Repository navigation
perf(recording): bound camera & converter frame queues by byte budget and drain macOS autorelease pools (#109) - #3935
Conversation
… and drain macOS autorelease pools Fixes CapSoftware#109 Signed-off-by: Lucas Oliveira <kalopsia3445@gmail.com>
|
@frds3445 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…d count only actual evictions
…rop narrating comments Include worker_count in bounded_for_conversion retained byte accounting, allow 1-frame camera channel bounds for ultra-high-res formats, and remove narrating comments per AGENTS.md.
|
Thanks @frds3445, this looks like a useful change. Before we can merge it:
Once that's sorted, request a re-review from Greptile. |
… output slot in budget
|
Thanks @richiemcilroy, sorted that out and re-ran Greptile on the latest commit (d35f41b), it is at 5/5 now. |
Summary
Bounds in-flight camera and frame-converter queues by explicit byte budgets and drains macOS Objective-C autorelease pools per frame during recording (#109):
crates/camera/src/macos.rsandcrates/frame-converter/src/videotoolbox.rsin explicit autorelease pool drains to avoid retaining transient Objective-C buffers across long sessions.crates/frame-converter/src/pool.rsandcrates/recording/src/sources/camera.rs.Fixes #109
/claim #109


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues remain.Summary
This PR limits memory held by camera and converter queues, bounds timing samples, and adds macOS buffer cleanup and reuse.
Reviews (8) · Last reviewed commit: "fix(frame-converter): reject conversions..." · Reviewed by Greptile