Repository navigation
Conversation
…tion tier, and startup health check (CapSoftware#73) - Add `upload_probe` module in `crates/recording` classifying upload throughput (`SpeedProbeSample`, `AdaptiveUploadTier`) into adaptive resolution caps (`1920`, `1280`, `854`) and `StudioQuality` presets while preventing speed probes during active recordings (`should_run_speed_probe`). - Extend `RecordingDefaults::with_upload_speed_mbps` to apply adaptive quality and resolution limits prior to recording startup. - Add `/api/upload/health-check` Web App API route (`apps/web/app/api/upload/health-check/route.ts`) and unit tests to validate startup screen-recording upload probes and surface user-facing support indicators on failure. Fixes CapSoftware#73 Signed-off-by: Lucas Oliveira <kalopsia3445@gmail.com>
Contributor
|
@frds3445 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
![superagent-security[bot]](https://avatars.githubusercontent.com/in/3287076?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…-IP rate limiting
…ed probe Integrate /api/upload/health-check with @effect/platform HttpApi, HttpAuthMiddleware, and Storage readiness checks, and wire startup speed probing into desktop-gpui and RecordingDefaults.
…e user quality settings
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
…ore base recording.rs
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements upload speed probing, adaptive recording resolution recommendations, and startup upload health verification for Cap (#73):
crates/recording/src/upload_probe.rsanddefaults.rs, classifies link quality, and applies resolution and quality caps when recordings start so constrained connections do not stall uploads.apps/web/app/api/upload/health-check/route.tsandroute.test.tsthat verifies user storage readiness and bounds probe payloads.Fixes #73
/claim #73
The PR appears safe to merge; the latest changes only remove comments.Summary
Adds startup upload checks and uses measured speed to cap recording settings.
Reviews (10) · Last reviewed commit: "style(web): remove redundant helper comm..." · Reviewed by Greptile