fix: lifetime memory growth from macOS permission-check SCShareableContent polling - #2064
Merged
Conversation
…ned mic feed locks
richiemcilroy
marked this pull request as ready for review
August 2, 2026 22:27
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2023 (CAP-761) and the swap-exhaustion incident documented in maxktz/cap-memory-leak-incident (Cap suspended by macOS at 82.29 GB).
Since ae303ef, the screen-recording permission check ran a full `SCShareableContent` enumeration, and polling callers (5s device-snapshot emitter, UI polls, 250ms onboarding poll) drove it on tokio threads with no autorelease pool for the entire process lifetime — measured at ~138 KB leaked per call (scales with system window count), matching the reported ~15–18 MiB/min growth.
Validated: `cargo clippy -D warnings` clean on all five touched crates; 31 microphone tests pass; a probe replicating the old call pattern shows ~138 KB/call linear growth unpooled vs flat (~1 KB/call) with the fix. Note #1589 (growth while a recording is paused) is a separate report and not addressed here.
Greptile Summary
The PR addresses long-running macOS memory growth by reducing repeated ScreenCaptureKit enumeration, introducing autorelease pools and explicit native-object cleanup, and bounding or cancelling microphone-related resources.
Confidence Score: 5/5
The PR appears safe to merge, with no concrete changed-code defect identified.
The resource-lifetime changes preserve existing capture and permission behavior while bounding retained state, serializing expensive validation, and releasing or draining native resources at their intended ownership boundaries.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(desktop): cap mic volume meter windo..." | Re-trigger Greptile
Context used: