Repository navigation
Use typed Git outcomes in checkout recovery and account layer writes - #5880
Merged
joelteply merged 1 commit intoNov 8, 2026
Conversation
…rites Integrates the typed outcome and porcelain portions of Fable PR5867 into the split arrival owner. Preserve off-anchor WIP, cancellation custody, and the real WorkSubmit recovery fixture. Route citizen metadata through the existing citizens disk class.
joelteply
merged commit Nov 8, 2026
dadccbc
into
f76005e8/arrival-never-moves-a-card-checkout-off
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kimi's checkout recovery was blocked by inherited Git error-text classifiers. This extracts the existing typed-outcome and porcelain changes from #5867 into #5877's split arrival code: remote absence uses Git exit 2, interrupted operations retain their typed outcome, and rejected pushes use porcelain output. Both inherited citizen metadata writes now use the registered citizens disk class.
This PR targets #5877's branch so only the seven-file integration delta is reviewed. It includes the independent shallow recovery and actual off-anchor WorkSubmit fixtures; no GitActor, sandbox, or secrets changes.
Validation: workspace-transfer tests 17 passed before the citizen writer follow-up; current source-hygiene base/head 95/95 passed (error-text sites 26→23, unaccounted writes 180→178). The class-writer test passed; integrated actual WorkSubmit is running. Cormac reviewed all seven files and passed exact dadccbc (local adoption into #5877 reported, remote update pending). Runtime deployment remains pending test completion.
A push authentication failure now reports Unreachable when Git provides no porcelain ref verdict; it is not asserted to be a remote ref rejection. The original error remains visible.