FIREFLY-1964: Alert Viewer UI Updates and add URL API support by kpuriIpac · Pull Request #1934 · Caltech-IPAC/firefly

kpuriIpac · 2026-04-09T00:32:39Z

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1964

UI changes according to ticket
Added support for URL API
Call Rubin Service (set it up via AppProperties so Rubin can configure it, relying on default fallback to work for firefly testing)
- URL uploads no longer supported, only Alert IDs (I can add back URL support as well - if we'd want that. In that case, server side code will bypass checking AppProperties for base URL and just rely on user entered URL to retrieve a FITs file)

Testing:
Firefly's AlertViewer: https://fireflydev.ipac.caltech.edu/firefly-1964-alert-viewer/firefly

Test out these Alert IDs:
- 170059278837088375, 170112073844916273
- They will fail on the above test build with Unable to retrieve the FITS file: 401 Unauthorized
- But you can checkout my branch and test the UI changes locally

robyww · 2026-04-10T16:48:06Z

Some initial feedback:

The title is just the FITS file, It should look nice, at the very least it should be: Alert: 170059278837088375.
The FITS images are not named: Science, Template, Difference
The primary purpose of the URL api is to take an alert id.
such as

http://localhost:8080/firefly/alertviewer?api=alert&id=170059278837088375

robyww

The code mostly looks fine. There are still several things to do the the UI and url api.

robyww · 2026-04-10T16:53:35Z

src/firefly/js/apps/alertviewer/AlertUploadPanel.jsx

@@ -176,6 +193,10 @@ function loadFromEntries(result) {

            dispatchPlotImage({plotId, wpRequest, viewerId: ALERT.IMG_VIEWER, setNewPlotAsActive: i === 0});


put the title in the wpRequest

robyww · 2026-04-10T16:54:32Z

src/firefly/js/apps/alertviewer/AlertResultView.jsx


    const {hasMainTable, hasDetailTable, hasImages} = useStoreConnector(getAlertData);
+    const {source, fileName} = useStoreConnector(() => getComponentState(ALERT.STATE_ID));
+    const alertTitle = fileName || source || 'Alert Viewer';


modify to have a better title.

robyww · 2026-04-10T16:56:21Z

src/firefly/js/api/webApiCommands/AlertViewerCommands.js

+    ],
+    parameters: {
+        source: {desc: 'FITS URL or alert id to populate into Alert Viewer', isRequired: true},
+        execute: 'true or false - if true execute the alert load immediately'


you don't need execute, it should just always execute.

there should just be an id parameter and it should load the alert.

kpuriIpac · 2026-04-13T15:51:27Z

@robyww I addressed the feedback. Can you take a look at the UI again? Didn't do a test build as we need to test this locally anyway.
(I kept the title as Alert ID: 170059278837088375 but formatted it to look a little better. Still thinking about better title text options).

robyww · 2026-04-13T20:53:31Z

This url is correct but it does not execute the search. It should.

http://localhost:8080/firefly/alertviewer?api=alert&id=170059278837088375

It only goes to the alert panel and shows an empty panel. It need to show an result.

robyww

I think this is almost done. The overall layout looks good.

Two big things:

The title
the URL Api showing results.

robyww · 2026-04-13T17:55:06Z

src/firefly/js/apps/alertviewer/AlertResultView.jsx

+            <Typography level='title-md' sx={{fontFamily: 'monospace'}} color='neutral'>
+                Alert ID: {id}
+            </Typography>


you don't need to change the font here. This is a title it should look very clean.

I the text should be 'title-md' and value (id) should be body-md

robyww · 2026-04-13T20:59:28Z

src/firefly/java/edu/caltech/ipac/firefly/server/query/alert/AlertViewerSearchProcessor.java

+                return makeError(source, "Unable to retrieve the FITS file for alert ID: " + source);
            }
            final int responseCode = fileInfo.getResponseCode();
            if (responseCode > 305 || responseCode < 200) {


make sure you response code align the the document response codes of the service.

Good point. This is too generic. I looked at the repsonse codes and messages for GET /api/alerts?ID={alert_id} at https://sqr-114.lsst.io/v/DM-54197/index.html and added the relevant messages for those exact response codes. For any other codes, I'll keep the existing generic message.

robyww · 2026-04-13T21:00:12Z

src/firefly/java/edu/caltech/ipac/firefly/server/query/alert/AlertViewerSearchProcessor.java

+        return baseUrl + joiner +
+                ALERT_ID + "=" + URLEncoder.encode(alertId, StandardCharsets.UTF_8) + "&" +
+                RESPONSEFORMAT + "=" + FITS_RESPONSE_FORMAT;


You could you String.format here.

robyww · 2026-04-13T21:02:44Z

src/firefly/js/api/webApiCommands/AlertViewerCommands.js

+    return [
+        {
+            cmd: 'alert',
+            validate: validateAlertViewer,
+            execute: showAlertViewer,
+            ...alertViewerOverview,
+            examples: makeExamples('alert', alertViewerExamples),
+        },


This is all good but it is not showing an alert result.

fixed! Took me too long to figure this out - but routed apps don't receive initArgs the same way as the rest of firefly. Just needed to use useContext(InitArgsCtx). We already do this for Euclid & Spherex.

kpuriIpac · 2026-04-14T00:23:58Z

@robyww addressed the last few changes and fixed URL API. Can you test once more and let me know if it all looks good?

kpuriIpac added this to the 2026.1 milestone Apr 9, 2026

kpuriIpac self-assigned this Apr 9, 2026

kpuriIpac added the enhancement label Apr 9, 2026

kpuriIpac force-pushed the FIREFLY-1964-alert-viewer branch from 6d155d4 to a208732 Compare April 10, 2026 01:25

kpuriIpac requested a review from robyww April 10, 2026 01:36

kpuriIpac marked this pull request as ready for review April 10, 2026 01:36

robyww reviewed Apr 10, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1964-alert-viewer branch from a208732 to 52b1291 Compare April 13, 2026 15:48

robyww requested changes Apr 13, 2026

View reviewed changes

kpuriIpac added 4 commits April 13, 2026 16:35

alert viewer UI updates and url api

f0d0f4d

setup calls to service and make alert ids work

88a24e5

address feedback and improve naming

c023387

more cleanups and addressing feedback

0ae5871

kpuriIpac force-pushed the FIREFLY-1964-alert-viewer branch 2 times, most recently from 4282437 to f80d656 Compare April 14, 2026 00:17

fix url api broken

69b483f

kpuriIpac force-pushed the FIREFLY-1964-alert-viewer branch from f80d656 to 69b483f Compare April 14, 2026 00:30

		@@ -176,6 +193,10 @@ function loadFromEntries(result) {

		dispatchPlotImage({plotId, wpRequest, viewerId: ALERT.IMG_VIEWER, setNewPlotAsActive: i === 0});

Conversation

kpuriIpac commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robyww commented Apr 10, 2026

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robyww commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kpuriIpac commented Apr 9, 2026 •

edited

Loading

kpuriIpac commented Apr 13, 2026 •

edited

Loading

robyww commented Apr 13, 2026 •

edited

Loading