Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CakePHP 5 compatibility fixes:
normalizeArray()now returnsname => config(theclass/configshape is gone), soService/Action::_loadExtensions()passed
nulltoload()and threw.string $role; integerroles (group ids) threw a
TypeError. Now cast to string.Adds regression tests (
ExtensionLoadingTest,ApiRbacTest) that fail beforethe fix. Plugin suite (130 tests) and a downstream app suite (1789 tests) pass.
Also adds
config.policy.advisories.ignore: ["league/flysystem"]so thetestsuitejob cancomposer update(it was blocked by flysystem 1.xadvisories pulled by the
flysystem-vfsdev-dependency).Refs #43963.