fix: shell located spheres and partial solids - #2101
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2101 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 30 30
Lines 9589 9593 +4
Branches 1439 1439
=======================================
+ Hits 9187 9191 +4
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2074.
A located solid inside the compound returned by
Workplane.findSolid()can make OpenCascade rejectshell()withBRep_API: command not done. Normalize child locations before the hollow operation. Map selected faces to the normalized shape so open shells retain their intended openings.Validation:
git diff --checkpassed.test_interpPlatenumeric failure before and after the change. On the base, it reported 891 passed, 3 skipped, and 1 failed. After the fix, it reported 893 passed, 3 skipped, and 1 failed. The expected volume is10.956054314; this environment computes10.338751346962978.Tested with CadQuery OCP 8.0.1.0. OCP 8.0.1.1 was not available from the local package index, so that version remains untested.
Codex used.