Conversation
package-lock.json
Outdated
There was a problem hiding this comment.
Not sure, but should this be gitignored or removed from this changeset? Was this change only generated because we installed from the local sdk?
There was a problem hiding this comment.
Yeah, that can definitely be removed. This may have been in part because I had been trying to get yarn to work right between this and the SDK
yarn.lock
Outdated
There was a problem hiding this comment.
Same as for package-lock.json, should this be removed from the PR, or is this a necessary part of the change?
| loggedInUser.eobData = {}; | ||
| process.stdout.write(ERR_QUERY_EOB + '\n'); | ||
| process.stderr.write("Exception: " + String(e) + '\n'); | ||
| if (e.response) { |
There was a problem hiding this comment.
@bwang-icf should this block be removed? Just given the checks that were called out below, or are we good to ignore those?
|
@bwang-icf I'm in the node-sdk repo, trying to make it so I can consume the updated sdk in the sample client. I am unable to run yarn build though, get an error that the command is not found. I'm on version 1.22.22, any advice on this? |
JamesDemeryNava
left a comment
JamesDemeryNava
left a comment
There was a problem hiding this comment.
Works for me after updating the SDK properly. Nicely done!
3 participants
Changes to allow v3 functionality in sample client by using the updated SDK. Includes some extra console.log messages for debugging but could be removed.
JIRA Ticket:
BB2-4376
What Does This PR Do?
Changes for v3 functionality in a local version of the sample client
What Should Reviewers Watch For?
Any breaking changes or unexpected behavior with v2 or v3.
Validation
Validated by way of local auth