BB2-3914: Fix formatting for headers#82
Merged
JamesDemeryNava merged 1 commit intomasterfrom Oct 27, 2025
Merged
Conversation
jimmyfagan
approved these changes
Oct 24, 2025
Contributor
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
(same comment as in the other repo) Looks great, my one question is whether or not we should eliminate usage of the h1, h2, etc in general instead of adding the revert in the css. If I'm understanding this correctly they'd have the same impact, but that might be a little more straightforward to not use revert.
But either way, this looks good when I run locally, so I'll mark this as approved, let me know if you decide to make a change and I can re-run and re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3914
What Does This PR Do?
Fixes the formatting of headers. The formatting was no longer correct after this merge.
The formatting was no longer correct after we updated the version of the CMS design system repo that we were using. When that update was performed, we also changed what styling files we were importing from the CMS design system repo, causing this formatting issue.
What Should Reviewers Watch For?
Ensure the formatting now looks correct.
If you're reviewing this PR, please check for these things in particular:
Validation
Pull this branch and build the project. Got to localhost:3000 in your browser and confirm the formatting matches the second screenshot in the ticket description.