Skip to content

feat(pull): check all files were downloaded #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjzegmott merged 3 commits into from
Feb 19, 2026
Merged

feat(pull): check all files were downloaded #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253d95a
test(pull): define specific files to reduce run time
tjzegmott Feb 19, 2026
bb1d8b6
feat(pull): check all files were downloaded
tjzegmott Feb 19, 2026
2c5a4c9
build(poetry): rebuild lock file
tjzegmott Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dtcli/pull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
exists=True, file_okay=True, dir_okay=False, writable=True, resolve_path=True
),
default=None,
help="Specific files to pull",
help="Path to file of specific files to pull.",
)
@click.option(
"--cores",
Expand Down Expand Up @@ -96,6 +96,7 @@ def pull( # noqa: C901
logger.exception(
"Configuration Missing!! Run `datatrail config init`.",
)
ctx.exit(1)
raise click.Abort()

try:
Expand Down Expand Up @@ -193,4 +194,13 @@ def pull( # noqa: C901
cores=cores,
verbose=verbose,
)
# Check that all files have been downloaded.
for f in files["missing"]:
local_path = path.join(directory, f.replace("cadc:CHIMEFRB", ""))
if not path.exists(local_path):
error_console.print(
f"File not downloaded: {local_path}",
style="bold red",
)
ctx.exit(1)
return None
Loading