Skip to content

fix(api): sort by _id instead of last.eid for eid pseudo-attribute #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakubMagda wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(api): sort by _id instead of last.eid for eid pseudo-attribute #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6eff8a
fix(api): sort by _id instead of last.eid for eid pseudo-attribute
JakubMagda Sep 21, 2026
b26f803
docs: clarify sort behavior
xsedla1o Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dp3/api/routers/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,14 @@ async def get_entity_type_eids(

# Apply sorting if specified
if sort_criteria:
# Prepare sort specification with 'last.' prefix for snapshot data
sort_spec = [("last." + attr, direction) for attr, direction in sort_criteria]
# 'eid' uses snapshot _id storage order so standalone EID sorts can use
# the _id index. This intentionally differs from natural EID order for
# some strings (bucket suffixes) and signed integers (binary encoding).
# Other attributes live under 'last.'
sort_spec = [
("_id" if attr == "eid" else "last." + attr, direction)
for attr, direction in sort_criteria
]
cursor = cursor.sort(sort_spec)

cursor_page = cursor.skip(skip).limit(limit)
Expand Down
Loading