Error handling improvements#154
Merged
Merged
Conversation
- Return raw `res` from `post` method so we can interact with it
appropriately depending on the response from the search service
- DRY up code in different search methods
- Make default friendly error message less generic, indicating the
search service encountered an error
- Handle different errors returned from search service
- RuntimeError - Failed to communicate with search service
- Forbidden - 40x response indicating access denied, indicating IP or
user/pass auth configuration requires attention
- BadRequest - Malformed request or search service syntax error,
including if the query includes a mix of smart and regular quotes
- ExceptionWithResponse - Catch all for all other errors
- Move post to protected methods - Alphabetize protected methods
Member
Author
|
Query string that will cause Elasticsearch to choke on a syntax error: |
wkdewey
approved these changes
Jul 14, 2026
wkdewey
left a comment
wkdewey
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good. Tested with TEAA.
| res = post("_search", req) | ||
| if res.class == RuntimeError | ||
| on_error(res.inspect, req, | ||
| "There was an error communicating with to the search service") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.