Allow disabling tests with CATKIN_ENABLE_TESTING#90
Merged
130s merged 2 commits intoCCNYRoboticsLab:ros1from Oct 17, 2023
Merged
Allow disabling tests with CATKIN_ENABLE_TESTING#90130s merged 2 commits intoCCNYRoboticsLab:ros1from
130s merged 2 commits intoCCNYRoboticsLab:ros1from
Conversation
130s
requested changes
Jun 27, 2023
Collaborator
130s
left a comment
There was a problem hiding this comment.
- Making the test as an option makes sense to me. For developers' usecases they may not always want to run tests.
- I found
rostest.add_rostestis a very strict so that can be even more strong motivation to disable the tests.
- I found
- I just merged CI change #88 (it was opened a while ago but had been unmerged) into
ros1branch, the same branch this PR is aiming to. Would @Smona you mind enabling the tests in the CI config?
Collaborator
|
Also do you mind @Smona cherry-picking the same changes into |
Author
|
Great, glad you are interested in merging this! I've create a ros2 branch rebase of this in #91. I'm not sure what test configuration you're asking for, since my understanding is that |
89300b8 to
018d67a
Compare
Author
|
@130s i've merged in the CI check, but I think you need to approve the run. |
130s
approved these changes
Oct 17, 2023
Collaborator
130s
left a comment
There was a problem hiding this comment.
Thanks for catching this up! Approving.
I'm not sure why CI has not run for this PR though, will see if it runs post-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most ROS packages now allow disabling test runs by setting
CATKIN_ENABLE_TESTINGto false.When I try to build
laser_scan_matcherwithCATKIN_ENABLE_TESTINGset to false, I get this error:This PR just uses the recommended method to disable tests when the user requests it.