[FEATURE] - PR3 : Web auth - #1198
Open
pulk17 wants to merge 3 commits into
Open
Conversation
pulk17
requested review from
canihavesomecoffee and
thealphadollar
as code owners
September 14, 2026 07:56
Vite + React + TypeScript setup for the web console under web/, with the shared styles, UI primitives and types the pages build on.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



[FEATURE]
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Signing in, recovering a password, and managing your own account. Depends on #1197.
What's here
The sign-in card, the standalone reset screen, and the account page (display name, email, password, GitHub connection, closing the account).
Account enumeration
Both the "forgot password" and "create an account" flows return the same confirmation whether or not the address exists - "If that address has an account, a reset link is on its way." That's intentional and matches what the API does; a different answer would let an anonymous caller discover who's registered.
What still finishes on the classic pages
Signup. complete_signup is the only place a User row is created, and duplicating that felt like the wrong trade. The console requests the link; the classic page completes it.
Password reset can move here, and does once CONSOLE_URL is set (PR 9). Until then the email keeps pointing at /account/reset.
GitHub
Connecting is an OAuth redirect that finishes on the platform's existing callback, so the console sends you there and picks up the result afterwards rather than handling the exchange itself. Disconnecting only clears the platform's stored token - the note in the UI says so, since the authorisation itself has to be withdrawn from GitHub.
Review notes
Changing your email requires the current password; changing your name doesn't. The minimum password length isn't duplicated in the frontend - the server reports it, so there's no second number to keep in sync.