Skip to content

[FEATURE] - PR3 : Web auth - #1198

Open
pulk17 wants to merge 3 commits into
CCExtractor:masterfrom
pulk17:web-auth
Open

[FEATURE] - PR3 : Web auth#1198
pulk17 wants to merge 3 commits into
CCExtractor:masterfrom
pulk17:web-auth

Conversation

@pulk17

@pulk17 pulk17 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[FEATURE]

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Signing in, recovering a password, and managing your own account. Depends on #1197.

What's here
The sign-in card, the standalone reset screen, and the account page (display name, email, password, GitHub connection, closing the account).

Account enumeration
Both the "forgot password" and "create an account" flows return the same confirmation whether or not the address exists - "If that address has an account, a reset link is on its way." That's intentional and matches what the API does; a different answer would let an anonymous caller discover who's registered.

What still finishes on the classic pages
Signup. complete_signup is the only place a User row is created, and duplicating that felt like the wrong trade. The console requests the link; the classic page completes it.

Password reset can move here, and does once CONSOLE_URL is set (PR 9). Until then the email keeps pointing at /account/reset.

GitHub
Connecting is an OAuth redirect that finishes on the platform's existing callback, so the console sends you there and picks up the result afterwards rather than handling the exchange itself. Disconnecting only clears the platform's stored token - the note in the UI says so, since the authorisation itself has to be withdrawn from GitHub.

Review notes
Changing your email requires the current password; changing your name doesn't. The minimum password length isn't duplicated in the frontend - the server reports it, so there's no second number to keep in sync.

Vite + React + TypeScript setup for the web console under web/, with the
shared styles, UI primitives and types the pages build on.
Typed client for the mod_api endpoints: fetch helpers carrying the bearer
session, and a TanStack Query hook per resource.
Sign in, the password reset screen the recovery email links to, and the
account page for profile, password and the GitHub connection.
@sonarqubecloud

Copy link
Copy Markdown

@pulk17 pulk17 changed the title Web auth [FEATURE] - PR3 : Web auth Sep 14, 2026
@pulk17 pulk17 mentioned this pull request Sep 14, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant