Fix integer overflow in MP4 timestamp calculations (GPAC path)#2205
Closed
Apprentice2907 wants to merge 5 commits intoCCExtractor:masterfrom
Closed
Fix integer overflow in MP4 timestamp calculations (GPAC path)#2205Apprentice2907 wants to merge 5 commits intoCCExtractor:masterfrom
Apprentice2907 wants to merge 5 commits intoCCExtractor:masterfrom
Conversation
Contributor
|
Closing this PR. A few issues:
This is the same feedback we gave on #2108 and #2106. Please take it into account going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Description
This PR fixes a potential integer overflow in MP4 timestamp calculations in the GPAC path.
Previously timestamps were computed using expressions like:
Since
DTSandCTS_Offsetare stored in 32-bit integers, the multiplication could overflow before the result was converted to a larger type. This could lead to incorrect subtitle timestamps in some cases.This patch ensures that the arithmetic is performed using 64-bit integers by casting operands to
int64_tbefore the calculation.Affected code paths include:
process_avc_sampleprocess_hevc_sampleprocess_xdvb_trackprocess_vobsub_trackprocessmp4sample processing loopThis change does not alter logic or functionality other than preventing overflow during timestamp calculation.
Repro instructions