fix: add link_directories for tesseract/leptonica on macOS#2186
Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom Mar 15, 2026
Merged
fix: add link_directories for tesseract/leptonica on macOS#2186cfsmp3 merged 1 commit intoCCExtractor:masterfrom
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
Conversation
cfsmp3
requested changes
Mar 14, 2026
Contributor
cfsmp3
left a comment
cfsmp3
left a comment
There was a problem hiding this comment.
The CMake link_directories fix is correct and we'd like to merge it — but the PR also includes unrelated mp4.c changes (ENABLE_FFMPEG_MP4 track counting) that belong in #2170.
Please remove the mp4.c changes from this PR so we can merge the tesseract/leptonica fix cleanly.
pkg_check_modules provides library names without paths. Without link_directories, the linker cannot find tesseract and leptonica on systems where they are not in default search paths (e.g. Homebrew on macOS arm64).
DhanushVarma-2
force-pushed
the
fix/macos-ocr-link-dirs
branch
from
bb87e7f to
bfa714b
Compare
Contributor
Author
Done 👍 |
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit ed7f544...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit ed7f544...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
cfsmp3
approved these changes
Mar 15, 2026
Contributor
cfsmp3
left a comment
cfsmp3
left a comment
There was a problem hiding this comment.
Clean fix — adds link_directories() for tesseract/leptonica so macOS Homebrew builds can find the libraries. No-op on Linux. Builds clean, tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes linker failure when building with -DWITH_OCR=ON -DWITH_HARDSUBX=ON on macOS arm64 (Homebrew).
pkg_check_modules populates TESSERACT_LIBRARY_DIRS and LEPTONICA_LIBRARY_DIRS but these were never passed to the linker. Added link_directories() calls in both the OCR and HARDSUBX sections of CMakeLists.txt.
Tested on macOS arm64 with Homebrew tesseract 5.5.1 and leptonica 1.86.0.