Monotonicity state moved into GenerationOptions instance making the state not globally shared#63
Merged
Merged
Conversation
… GenerationOptions instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The state necessary for monotonic ULID generation is now part of
GenerationOptionsinstance instead of being globally shared. This fixes potential conflicts between different monotonic options being employed with all of them sharing the same state.Documentation is updated accordingly.
Benchmarks were not affected.
Type of Change
Checklist
main)..editorconfig)Additional Notes
Theoretically it is a breaking change as each
GenerationOptionsinstance holds its own state. In practice, only better performance and more reasonably expected generated ULIDs should be the result.