Fix current_time and put all the time getting code in one place#200
Open
Un1q32 wants to merge 12 commits into
Open
Fix current_time and put all the time getting code in one place#200Un1q32 wants to merge 12 commits into
Un1q32 wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current_time is supposed to return the time since game start, but in butterscotch, depending on the platform, current_time could return the time since the system booted, or the time since January 1st 1970. This fixes that.
This PR also centralizes all the different time getting code I know of into one place that the whole program can use, instead of having various platform dependent time getting implementations scattered across the codebase. This should make it easier to add a new platform with different time getting code since you don't have to duplicate your code across multiple different places.