Scenario workflow: 1. plan for developing the Scenario workflow - #5
Open
JieXiong9119 wants to merge 11 commits into
Open
Scenario workflow: 1. plan for developing the Scenario workflow#5JieXiong9119 wants to merge 11 commits into
JieXiong9119 wants to merge 11 commits into
Conversation
…ontract Scenario workflow: 4. parser warning
…ndex Scenario workflow: 3. measure parser
…data-model-and-discovery Scenario workflow: 2. scenario data model and discovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1-4 Summary
This PR set lays the foundation for translating BuildingSync
PackageOfMeasuresscenarios into OpenStudio workflows. It does not change the current baseline-only workflow behavior yet. BOSS still writes and runsbaseline/in.oswas before.PR 1: Scenario Workflow Plan
Added a roadmap for scenario workflow translation.
The plan defines:
PR 2: Scenario Discovery
Added reader support for discovering report-level scenarios from the first facility.
BOSS can now read package-of-measures scenario data, including:
MeasureIDvalues.This keeps existing reader behavior unchanged while exposing the scenario data needed by later PRs.
PR 3: Measure Index
Added reader support for indexing measures from the first facility.
BOSS can now look up measures by ID and read useful measure metadata, including:
Missing optional fields return
nilor empty arrays instead of breaking parsing.PR 4: Parser Warnings
Added a structured warning contract for incomplete or unusable scenario and measure data.
Warnings now cover cases such as:
MeasureIDreferences.These warnings are returned as structured data, so later mapping and workflow code can handle them consistently.
Verification
Focused reader tests were added or updated for PRs 2-4.
Verified with:
bundle exec rspec spec/tests/unit/buildingsync_reader_spec.rbLatest focused unit result:
RuboCop was also checked on the changed reader/spec files. It still reports existing style debt and new-cop configuration warnings, but no new functional blocker was identified for the PR scope.