fix(webcomponents): publish SRI manifest [ENG-13134] - #4816
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/react |
❌ Failed | 6m 2s | View ↗ |
nx test @e2e/nextjs-sdk-next-app |
✅ Succeeded | 9m | View ↗ |
nx test @snippet/angular-17-ssr |
✅ Succeeded | 11m 56s | View ↗ |
nx test @snippet/gen1-next14-pages |
✅ Succeeded | 11m 25s | View ↗ |
nx test @e2e/qwik-city |
✅ Succeeded | 10m 4s | View ↗ |
nx test @e2e/solid-start |
✅ Succeeded | 7m 49s | View ↗ |
nx test @e2e/sveltekit |
✅ Succeeded | 10m 44s | View ↗ |
nx test @e2e/hydrogen |
✅ Succeeded | 9m 57s | View ↗ |
Additional runs (24) |
✅ Succeeded | ... | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-08-19 20:52:06 UTC
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
This PR adds a small Node-based release helper that reads the webcomponents package version, hashes the published dist/system/builder-webcomponents-async.js artifact with SHA-384, and writes a newline-terminated sri-manifest.json. The build script cleans stale manifest output before rebuilding and invokes manifest generation after the unpkg distribution step, while focused tests cover both successful output and a missing artifact.
The approach is sound for the intended release artifact: the generator uses the exact bytes from disk, preserves the package version, fails naturally when required inputs are missing, and is safely executable both as a CLI and an imported helper. Both parallel reviewers found the same low-severity process concern: the repository's ci:test --if-present convention does not run these new Jest tests because this package has no ci:test script. This is not included as an actionable inline finding at the selected standard-risk threshold, but adding a non-watch CI test script would improve regression protection.
Risk assessment: Standard (release/build behavior and published artifact integrity).
✅ No confirmed bugs were found in build sequencing, artifact path selection, hashing, or manifest packaging.
🧪 Browser testing: Skipped — PR only modifies backend/config/docs, no UI impact

Summary
Jira
ENG-13134
Validation