[react-native] Support for react-dom@19#4108
Conversation
🦋 Changeset detectedLatest commit: af4e2a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit af4e2a7.
☁️ Nx Cloud last updated this comment at |
|
On as side note, I gave react-compiler a try on our Expo app and it failed. It seems related to Builder as the In the following example {
name: "MyComponent",
component: ({ children }) => {
console.log(children[0].type)
return children
},
canHaveChildren: true,
}I will find some time for testing and maybe opening an other PR for react-compiler support |
sidmohanty11
left a comment
There was a problem hiding this comment.
thanks for the fix @kerwanp !! LGTM.
| "@builder.io/sdk-react-native": patch | ||
| --- | ||
|
|
||
| Add support for React 19 |
There was a problem hiding this comment.
| Add support for React 19 | |
| Fix: Add support for React 19 by handling `findDOMNode` deprecation |
Description
In react-dom@19 the function
findDOMNodehas been removed. Instead therefactually contains the Element.To support both 18 and 19 version we check wether
findDOMNodeis defined.