Skip to content

feat: refactor admin initialization to CLI and implement lobby WebSoc…#80

Merged
aniebietafia merged 2 commits into
mainfrom
feat/create_admin_script
May 29, 2026
Merged

feat: refactor admin initialization to CLI and implement lobby WebSoc…#80
aniebietafia merged 2 commits into
mainfrom
feat/create_admin_script

Conversation

@aniebietafia
Copy link
Copy Markdown
Contributor

…ket notifications

  • Removed legacy admin initialization from application startup lifespan.
    • Replaced it with a Typer-based CLI tool (python -m app) supporting create-admin (interactive and --no-input), promote-admin, demote-admin (with last admin safety guard), and list-admins commands.
    • Cleared legacy admin environment variables from settings config and .env files.
  • Added a dedicated lobby WebSocket endpoint at /ws/lobby/{room_code}.
    • Extended ConnectionManager with a separate registry and Redis Pub/Sub channel (ws:lobby:{room_code}) to isolate lobby messages.
    • Added reject, admit-all, and reject-all REST endpoints for host actions.
    • Ensured waitlisted users are persisted to the database on admission and notified dynamically.

…ket notifications

- Removed legacy admin initialization from application startup lifespan.
  - Replaced it with a Typer-based CLI tool (python -m app) supporting create-admin (interactive and --no-input), promote-admin, demote-admin (with last admin safety guard), and list-admins commands.
  - Cleared legacy admin environment variables from settings config and .env files.
- Added a dedicated lobby WebSocket endpoint at `/ws/lobby/{room_code}`.
  - Extended ConnectionManager with a separate registry and Redis Pub/Sub channel (`ws:lobby:{room_code}`) to isolate lobby messages.
  - Added reject, admit-all, and reject-all REST endpoints for host actions.
  - Ensured waitlisted users are persisted to the database on admission and notified dynamically.

Signed-off-by: aniebietafia <aniebietafia87@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@aniebietafia, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 54 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ee9fb13-2b8e-4c19-8241-9c92beba6d25

📥 Commits

Reviewing files that changed from the base of the PR and between 0826958 and 6a04573.

📒 Files selected for processing (14)
  • .env.prod.example
  • app/__main__.py
  • app/cli.py
  • app/core/config.py
  • app/core/init_admin.py
  • app/main.py
  • app/modules/meeting/api_docs.md
  • app/modules/meeting/constants.py
  • app/modules/meeting/router.py
  • app/modules/meeting/service.py
  • app/modules/meeting/ws_dependencies.py
  • app/modules/meeting/ws_router.py
  • app/services/connection_manager.py
  • tests/meeting/test_meeting_service.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/create_admin_script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: aniebietafia <aniebietafia87@gmail.com>
@aniebietafia aniebietafia merged commit 763a9cd into main May 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant