simplify Is* checks #404
Open
simplify Is* checks #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested in classic era, later I'll test in tbc too |
Contributor
Author
|
tested in tbc too |
This was referenced Jan 26, 2026
BreakBB
requested changes
Jan 28, 2026
Owner
BreakBB
left a comment
BreakBB
left a comment
There was a problem hiding this comment.
I just added ECS.IsEra which is most likely what you need, because the current usage of ECS.IsClassic is incorrect in many places. ECS.IsClassic is also true for SoD, which therefore would currently hide things like haste and armor pen in SoD.
BreakBB
reviewed
Jan 29, 2026
| hidden = function() | ||
| return (not ECS.IsWotlk) | ||
| end, | ||
| hidden = function() return ECS.IsClassic end, |
Owner
There was a problem hiding this comment.
I think all of these ECS.IsClassic checks should now be ECS.IsEra because we want to see them in SoD.
Contributor
Author
There was a problem hiding this comment.
I'll do that in a different pr
Contributor
Author
There was a problem hiding this comment.
Armor penetration is on hold until I get some actual item with arpen to test with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.