Use filename timestamp for backup ordering and move to Utilities

[Copilot]

Changes proposed in this pull request

• Extract timestamp directly from backup filename (yyyyMMddHHmmss prefix) for ordering instead of relying on File.GetCreationTime
• Add ExtractTimestampFromFilename method to TimestampHelper.cs in Utilities project to parse filename timestamps with InvariantCulture for consistent behavior
• Update CleanupBackups to use extracted timestamps, ensuring reliable ordering across file systems and copy operations
• Refactor ExtractTimestampFromFilename as a public utility method in TimestampHelper.cs, making it reusable across the codebase

Related issue(s)

• Related to Feature: Daily settings backup #3283

Copilot generated summary

Copilot summary

File creation timestamps are unreliable across different file systems and after file operations like copying. Since backup filenames follow the format yyyyMMddHHmmss_Settings.json (e.g., 20241225182301_Settings.json), we now extract and parse this embedded timestamp for ordering. Invalid filenames return DateTime.MinValue to sort as oldest.

Changes:

• Added ExtractTimestampFromFilename helper method to TimestampHelper.cs in Utilities with proper culture-invariant parsing
• Made the method public and general-purpose for reuse across the codebase
• Modified CleanupBackups ordering from File.GetCreationTime(f) to TimestampHelper.ExtractTimestampFromFilename(f)
• Updated documentation to reflect new ordering approach
• Removed logging dependency from utility method (Utilities shouldn't depend on log4net)

To-Do

• Update documentation to reflect this changes
• Update changelog to reflect this changes

Contributing

By submitting this pull request, I confirm the following:

• I have read and understood the contributing guidelines and the code of conduct.
• I have have added my name, username or email to the contributors list or don't want to.
• The code or resource is compatible with the GNU General Public License v3.0.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[BornToBeRoot]

@copilot move the method ExtractTimestampFromFilename to the Utilities (in an existing file or create a new if necessary)

[Copilot]

@copilot move the method ExtractTimestampFromFilename to the Utilities (in an existing file or create a new if necessary)

Done! Moved ExtractTimestampFromFilename to TimestampHelper.cs in the Utilities project. The method is now public and more general-purpose, and I removed the logging dependency since Utilities shouldn't depend on log4net. See commits f56dc1c and e78a716.

[Copilot]

Pull request overview

This PR refactors the backup file ordering mechanism to use timestamps extracted directly from filenames instead of relying on file system creation times, ensuring consistent behavior across different file systems and after file operations.

• Extracts timestamps from backup filenames (yyyyMMddHHmmss prefix) for reliable ordering
• Adds three new utility methods to TimestampHelper for timestamp-based filename operations
• Updates CleanupBackups to use filename-based timestamps with culture-invariant parsing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
Source/NETworkManager.Utilities/TimestampHelper.cs	Adds three new public methods: GetTimestampFilename, IsTimestampedFilename, and ExtractTimestampFromFilename for generating, validating, and parsing timestamped filenames
Source/NETworkManager.Settings/SettingsManager.cs	Refactors backup creation calls to use GetTimestampFilename and updates CleanupBackups to filter and order backups using filename-based timestamps instead of file creation time

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.