Repository navigation
Check every published module against the registries - #6
Merged
Merged
Conversation
The release check looked only at the root artifact, so a retry after a GitHub Packages deploy that stopped partway through a multi-module release took the root's presence to mean every module was there and skipped the rest. The check now lists every module from the effective POM with the publish profile and checks each one, leaving out modules the build keeps out of a registry (maven.deploy.skip for GitHub Packages, skipPublishing for Central). A registry counts as done only when it has every module. If it has some but not all, the run stops with an error naming both sets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release check looked only at the root artifact. In a multi-module release, GitHub Packages receives modules one at a time, so a deploy that stopped partway left some modules there and not others. A retry then saw the root, decided GitHub Packages was done, and skipped the rest.
What changes in
maven-release.ymlpublishprofile (help:effective-pom) and lists every module.maven.deploy.skipfor GitHub Packages,skipPublishingfor Central.artifactoutput is still the root's.Tested
skipPublishing: it is left out of the Central check only.bonfire-oss-parentatv2.1.1, the script reports the tag, Central and GitHub Packages as already done, with exit 0.actionlint was not run.