Skip to content

Restore even if cannot set writable permissions. Fixes #437 - #447

Open
bwmarkle wants to merge 5 commits into
masterfrom
issue-437
Open

Restore even if cannot set writable permissions. Fixes #437#447
bwmarkle wants to merge 5 commits into
masterfrom
issue-437

Conversation

@bwmarkle

Copy link
Copy Markdown
Contributor

No description provided.

@bwmarkle

Copy link
Copy Markdown
Contributor Author

@cssjoe says:

the message changed to:
Total Upkeep - Restoration failed
Could not copy file.: wp-config.php
I chown 0:0 wp-config.php for the test restore.
It still says it failed. Should it say success with errors, or partially restored?

I'm going to put this PR on hold so we can get some releases out today.

  1. Looks like I missed some logic that needs to be accounted for.
  2. Thus far, only 1 report. Edge case?

@codecov-io

codecov-io commented Feb 16, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.46%. Comparing base (6d78a90) to head (32c9ba5).
⚠️ Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     25.46%   25.46%           
  Complexity     2920     2920           
=========================================
  Files           202      202           
  Lines         14698    14697    -1     
=========================================
  Hits           3743     3743           
+ Misses        10955    10954    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cssjoe

cssjoe commented Mar 5, 2021

Copy link
Copy Markdown
Member

This may need better result messages.

  • Completes successfully
  • Completed with errors; partially restored -- Maybe have an expandable file list
  • Could not restore -- with the reason(s)

@cssjoe

cssjoe commented Aug 3, 2026

Copy link
Copy Markdown
Member

Status update (Aug 2026 triage): Still open and still relevant — master still aborts restore when set_writable_permissions() fails (with ZipArchive). Prior hold notes about clearer result messaging (“completed with errors” / partial restore) still apply before merge. PR is mergeable; needs a product decision on messaging, then rebase/merge or a refreshed PR.

@cssjoe cssjoe mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants