fix(prompts): point tool-enablement guidance at Customize → Tools - #1120
Merged
philmerrell merged 1 commit intoSep 15, 2026
Merged
Conversation
The composer settings drawer was deleted by the Customize epic (docs/specs/customize-surface.md: "Does the settings icon survive? No."), but the prompt and UI copy kept directing users to "the gear icon next to the message input". Model- and user-facing: - system_prompt_builder.py HANDLING MISSING TOOLS — intro, step 2, and the worked example, which is a verbatim reply template the model reproduced word-for-word. - inference_api/chat/routes.py — the spreadsheet and PowerPoint diversion notes, which are appended to the user's own message and render in-thread. - chat-input.component.ts — the "Enable Spreadsheet Analysis" toast. Also drops "for this conversation" from the example reply: tool toggles at /customize/tools are user-level preferences, not conversation-scoped. Swept the rest of the tree for the same staleness: an admin placeholder claiming the prompt description is shown in the conversation settings panel (it is shown nowhere today) and five docstrings naming model-settings, the drawer, or "the My Skills page". Note: the code prompt is only the fallback — seed_bootstrap_data.py seeds no prompt text, so a deployed prompt edited through admin CRUD keeps its old copy. Deployed environments need checking separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
philmerrell
deleted the
claude/outdated-ui-system-instructions-548998
branch
September 15, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Customize epic deleted the composer settings drawer —
docs/specs/customize-surface.mdis explicit about it ("Does the settings icon survive? No."), andcomponents/model-settings/is gone. But the prompt and UI copy never followed, so we are still telling users to open "the gear icon next to the message input".The composer today has attach (
+), microphone, model dropdown and send. There is no gear. Tool enablement lives at/customize/tools, reached from the sidebar's Customize entry.What changed
Model- and user-facing:
system_prompt_builder.py—HANDLING MISSING TOOLSintro, step 2, and the worked example. The example is the worst of the set: it is a verbatim reply template, so the model reproduced the wrong instruction word-for-word.inference_api/chat/routes.py— the spreadsheet and PowerPoint attachment-diversion notes. These are appended to the user's own message, so the user reads the wrong direction in-thread, not just via the model.chat-input.component.ts— the "Enable Spreadsheet Analysis" nudge toast, found in the sweep.Also drops "for this conversation" from the example reply: the toggles at
/customize/toolsare user-level preferences, not conversation-scoped.Swept the rest of the tree for the same staleness: an admin placeholder claiming the prompt description is "shown to users in the conversation settings panel" (it is shown nowhere today), and five docstrings naming
model-settings, the drawer, or "the My Skills page".Not changed, but worth knowing
The code prompt is only the fallback.
seed_bootstrap_data.pyseeds no prompt text, so a dev/prod prompt edited through admin CRUD keeps whatever copy it was saved with. This PR does not fix a deployed environment — the DynamoDB prompt records need checking separately.respectAgentLock: trueis now a dead default. Every live caller passesfalse; the conversation surface that neededtruewas the drawer. The comment is corrected to stop naming a deleted surface, but the behavior is untouched — removing the parameter is a refactor, not a copy fix.Cost note
This rewrites the system-prompt prefix once on deploy — an unavoidable one-time cache miss per session, not a recurring one. Nothing about the change is per-turn or order-dependent, so the prompt-cache contract is unaffected.
Verification
agents/main_agent/core/+test_stream_processor.pypass; 29 attachment/diversion tests pass.gear icon/model settings panel/next to the message input/conversation settings panel/My Skills pageacrossbackend/src,frontend/ai.client/src,docs-site/srcreturns nothing.🤖 Generated with Claude Code