Skip to content

Improve the PR template - #581

Closed
halldorfannar wants to merge 15 commits into
BoboTiG:mainfrom
halldorfannar:task/improve-pr-template
Closed

Improve the PR template#581
halldorfannar wants to merge 15 commits into
BoboTiG:mainfrom
halldorfannar:task/improve-pr-template

Conversation

@halldorfannar

Copy link
Copy Markdown
Contributor

There are a few goals with this change, and I list them below. Please suggest tweaks or better wording. English is my third language 😄

  • Make the PR template simpler
    • remove the heading because every PR has a Title that is outside this template
    • instead of the "open to interpretation" (...) we now have a comment that tells contributors what we expect
  • Make the template reflect our new reality
    • We now have release notes instead of a changelog. We probably need more docs about how contributors are expected to update the release notes. Maybe those guides exist and I just couldn't find them.
  • Drive contributors to take action on all items
    • before they would only check if a test was added/update, etc but this makes the GitHub interface look odd because a PR will show as having incomplete tasks.
    • similarly, with the changed wording for AI disclosure we can tell if people took action there or not. If someone doesn't disclose we will assume AI was at least partially involved.
  • Tests added/updated (or your review concluded: not needed)
  • Documentation updated (or your review concluded: not needed)
  • Release notes added (or your review concluded: not needed)
  • ./check.sh passed

AI assistance disclosure

  • AI was not used to create this change.

@halldorfannar
halldorfannar marked this pull request as draft August 28, 2026 14:01
@halldorfannar

Copy link
Copy Markdown
Contributor Author

Created this from the wrong base branch. Will close and create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant