Safer jit and improved DSL specs - #732
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Empty constructors and several reductions mishandle newly documented per-call JIT options.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds safer native JIT fallback and configuration, while expanding Python-like DSL syntax and backend consistency.
Changes:
- Adds global/scoped JIT policies and safer TCC/CC fallback.
- Supports docstrings, semicolons, numeric literals,
pass, and chained comparisons. - Expands integration tests and JIT/DSL documentation.
| File | Description |
|---|---|
AGENTS.md |
Clarifies repository operation policy. |
CMakeLists.txt |
Updates miniexpr dependency. |
RELEASE_NOTES.md |
Records JIT and DSL changes. |
doc/conf.py |
Updates generated reduction guidance. |
doc/reference/dsl_syntax.md |
Documents expanded DSL syntax. |
doc/reference/index.rst |
Adds JIT reference page. |
doc/reference/jit.rst |
Documents JIT configuration and fallback. |
doc/reference/lazyarray.rst |
Links LazyArray JIT guidance. |
doc/reference/ndarray.rst |
Documents constructor JIT options. |
doc/reference/reduction_functions.rst |
Documents reduction JIT options. |
plans/portable-DSLs.md |
Proposes portable DSL artifacts. |
plans/safer-jit-execution.md |
Records implementation plan. |
plans/safer-jit-review.md |
Records validation and risks. |
src/blosc2/__init__.py |
Exports JIT configuration APIs. |
src/blosc2/blosc2_ext.pyx |
Passes configuration into miniexpr. |
src/blosc2/dsl_compare.py |
Lowers JavaScript comparison chains. |
src/blosc2/dsl_js.py |
Supports chains and pass in JavaScript. |
src/blosc2/dsl_kernel.py |
Expands DSL validation and emission. |
src/blosc2/jit_config.py |
Implements global and scoped JIT settings. |
src/blosc2/lazyexpr.py |
Applies JIT policy during evaluation. |
src/blosc2/ndarray.py |
Documents ramp-constructor JIT options. |
tests/ndarray/safer_jit_libtcc.c |
Provides relocation-failure test double. |
tests/ndarray/safer_jit_probe.py |
Exercises fresh-process JIT paths. |
tests/ndarray/test_dsl_comparisons.py |
Tests chained-comparison semantics. |
tests/ndarray/test_dsl_js.py |
Tests JavaScript DSL extensions. |
tests/ndarray/test_dsl_kernels.py |
Tests expanded native DSL syntax. |
tests/ndarray/test_jit_options.py |
Tests configuration precedence and scope. |
tests/ndarray/test_safer_jit.py |
Tests quiet fallback and caching. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In this PR:
Fixes #730