Feat/vscode enhance #199

Patotking12 · 2026-01-22T23:15:02Z

Added build integration to the VSCode extension with a task provider that runs simc and shows output in a dedicated channel. Also added code snippets for common patterns and custom file icons for .simf and .wit files.

On the LSP side, implemented document symbols for the outline view, signature help for function parameter hints, semantic tokens for AST-based highlighting of functions and namespaces, and witness file validation that checks types and reports missing or extra fields in real-time.

delta1 · 2026-01-23T10:11:02Z

Thanks @Patotking12 ! Could you please run rustfmt and eslint, see the CI jobs

Patotking12 · 2026-01-23T12:38:41Z

Done! Fixed the eslint issue. CI should pass now. @delta1

gerau · 2026-01-23T14:25:02Z

vscode/src/compile.ts

+    }
+
+    throw new Error(
+      "simc compiler not found. Install it with: cargo install --path . " +


It's better to leave a link to SimplicityHL readme, because cargo install --path . don't do anything on it's own

Updated to link to the README instead

gerau · 2026-01-23T14:30:44Z

lsp/src/backend.rs

+            if !value_str.starts_with("0x") {
+                if let Some(pos) = find_value_position(text, name, "value") {
+                    diagnostics.push(Diagnostic::new_simple(
+                        Range::new(pos, pos),
+                        format!("Witness '{}' value must start with '0x' (hex format)", name),
+                    ));
+                }
+            }


The witness is not required to be a hex number

Good catch, totally slipped my mind to remove that

The witness validation was added as a basic example to show we can validate .wit files in real-time (checking JSON structure, required fields)

gerau · 2026-01-23T14:40:09Z

lsp/src/backend.rs

    )
 }

+/// Validate a witness (.wit) file and return diagnostics.


It would be nice if the functions below could be moved into utils.rs

Good suggestion, moved the helper functions to utils.rs for better organization

Also moved the related tests to utils.rs since the functions they test now live there

gerau · 2026-01-23T15:02:06Z

vscode/src/compile.ts

+  // Parse simc error output into VSCode diagnostics.
+  // Error format:
+  //   |
+  // 1 | let a1: List<u32, 5> = None;
+  //   |              ^^^^^^ Expected a power of two...
+  public parseErrors(output: string): vscode.Diagnostic[] {
+    const diagnostics: vscode.Diagnostic[] = [];


Don't we already have diagnostics via LSP?
The language server output matches simc, so it's essentially showing the same problem twice.

The compiler diagnostics are intentional, they show the actual simc output when you run a build command

The LSP provides real-time feedback while editing, but the compiler is the source of truth

There is some overlap when both report the same error, but the compiler output is useful for the build workflow as it shows exactly what simc says. Happy to remove if you think it's too redundant

I like having the idea of diagnostics from simc, as it is really helpful for testing; however, I don't think that we need it right now for three reasons:

In most cases, it overlaps with LSP diagnostics.

In cases where it doesn't overlap (like errors for missing witnesses or params), it doesn't show the position of the problem, so it isn't very helpful.

If the display of errors changes, we would be required to rewrite this part, making it harder to maintain.

So, for now, I think we should not parse errors from the simc output, but in the future we could look into implementing this differently.

Ok, will proceed to remove it

gerau · 2026-01-23T15:11:53Z

I don't think we need to add more examples to vscode/examples. While it's good to showcase the extension's capabilities, we already have examples in this repo.

Patotking12 · 2026-01-24T14:29:36Z

Also deleted the examples folder I added

gerau

Thank you for your PR and fixes! These are really great features for the development experience.

Could you please resolve these issues and squash or restructure the later commits so the final history looks like your first three commits?

gerau · 2026-01-26T13:12:55Z

vscode/src/compile_commands.ts

+        const action = await vscode.window.showInformationMessage(
+          "SimplicityHL compiled successfully!",
+          "Copy Program",
+          "Copy Both",
+          "Dismiss"
+        );


I think we should remove "Copy Both" and the related code for this action, as it compiles without a witness. We should also create a similar action prompt for the "simplicityhl.compileWithWitness" command to handle this functionality.

Removed "Copy Both" from basic compile

Added "Copy Program" and "Copy Witness" options to the witness compile command instead

gerau · 2026-01-26T13:29:41Z

vscode/src/tasks.ts

+  // Locate simc compiler, fallback to cargo run if not installed
+  private async getSimcPath(): Promise<string> {
+    const config = vscode.workspace.getConfiguration("simplicityhl");
+    const configuredPath = config.get<string>("compiler.path");
+    if (configuredPath?.trim()) {
+      return configuredPath;
+    }
+
+    const simcPath = findExecutable("simc");
+    if (simcPath) {
+      return simcPath;
+    }
+
+    // Fallback: run via cargo (useful during development)
+    return "cargo run --release --";
+  }
+}


Can we import getSimcPath from compile.ts instead of redefining it here?

Done, now imports from compile.ts

gerau · 2026-01-26T13:37:12Z

lsp/src/backend.rs

+#[allow(dead_code)]
+mod semantic_token_types {
+    pub const FUNCTION: u32 = 0;
+    pub const PARAMETER: u32 = 1;
+    pub const VARIABLE: u32 = 2;
+    pub const TYPE: u32 = 3;
+    pub const KEYWORD: u32 = 4;
+    pub const NAMESPACE: u32 = 5;
+}
+
+/// Get the semantic token legend for this server
+fn get_semantic_token_legend() -> SemanticTokensLegend {
+    SemanticTokensLegend {
+        token_types: vec![
+            SemanticTokenType::FUNCTION,
+            SemanticTokenType::PARAMETER,
+            SemanticTokenType::VARIABLE,
+            SemanticTokenType::TYPE,
+            SemanticTokenType::KEYWORD,
+            SemanticTokenType::NAMESPACE,
+        ],


Could you remove #[allow(dead_code)] and delete unused semantic token types?

Removed and deleted the unused

gerau · 2026-01-26T13:42:31Z

vscode/docs/updates.md

I think it might be better suited for the PR description rather than the docs/ folder, which is usually for actual documentation.

Deleted the file

…ss validation

Patotking12 · 2026-01-26T20:53:41Z

Done, squashed everything into 3 clean commits

gerau · 2026-01-27T14:33:34Z

ACK dc3e43e

Update .gitignore

e8abe53

Patotking12 requested a review from delta1 as a code owner January 22, 2026 23:15

gerau reviewed Jan 23, 2026

View reviewed changes

gerau suggested changes Jan 26, 2026

View reviewed changes

Patotking12 added 2 commits January 26, 2026 14:43

lsp: Add document symbols, signature help, semantic tokens, and witne…

4b72c7c

…ss validation

vscode: Add build integration, status bar, snippets, and file icons

dc3e43e

Patotking12 force-pushed the feat/vscode-enhance branch from 665dce8 to dc3e43e Compare January 26, 2026 20:49

Patotking12 requested a review from gerau January 27, 2026 14:22

Feat/vscode enhance #199

Are you sure you want to change the base?

Feat/vscode enhance #199

Conversation

Patotking12 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delta1 commented Jan 23, 2026

Uh oh!

Patotking12 commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gerau commented Jan 23, 2026

Uh oh!

Patotking12 commented Jan 24, 2026

Uh oh!

gerau left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Patotking12 commented Jan 26, 2026

Uh oh!

gerau commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Patotking12 commented Jan 22, 2026 •

edited

Loading

gerau left a comment •

edited

Loading