Skip to content

fix(electrum): return JSON-RPC error for unknown methods instead of dropping the connection #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EddieHouston wants to merge 1 commit into
base: new-index
Choose a base branch
from
Open

fix(electrum): return JSON-RPC error for unknown methods instead of dropping the connection #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/electrum/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,10 @@ impl Connection {
#[cfg(feature = "electrum-discovery")]
"server.add_peer" => self.server_add_peer(&params),

&_ => bail!("unknown method {} {:?}", method, params),
&_ => Err(format!("unknown method {}", method).into()),
};
timer.observe_duration();
// TODO: return application errors should be sent to the client
// TODO: return errors as JSON-RPC 2.0 error objects ({code, message}) instead of bare strings
Ok(match result {
Ok(result) => json!({"jsonrpc": "2.0", "id": id, "result": result}),
Err(e) => {
Expand Down
Loading