Skip to content

fix(solana): image submit timeout + no phantom booking on video edge 5xx (0.52.3) - #160

Merged
VickyXAI merged 2 commits into
mainfrom
fix/solana-submit-timeouts
Sep 29, 2026
Merged

VickyXAI merged 2 commits into
mainfrom
fix/solana-submit-timeouts

Conversation

@VickyXAI

Copy link
Copy Markdown
Contributor

Hotfix for two defects in 0.52.2 (#159), found by the code review of #155.

1. The Solana image fix cut the paid submit off at 30s

#159 moved the Solana image rail onto solanaPaidAsyncPost but kept its 30s submit default (sized for video's 3–20s enqueue). The image route holds the paid POST up to ~30s and answers 202 + poll_url at the window's end — so the client aborted exactly when the job id was due, after the transfer settled. The fix never reached its target case, and renders finishing inline just past 30s (which 0.52.1 delivered) were lost too. Now SOLANA_IMAGE_SUBMIT_TIMEOUT_MS = 95_000, matching the account rail's submit timeout for the same window.

2. Edge 5xx on a Solana video submit booked a phantom charge

#159 left the tracker armed on any 502/503/504 at submit. Correct for image/music (settle at POST); wrong for video (settles on the completed poll). New option submitMaySettle (default true, conservative); video passes false.

Tests

  • Helper: edge 502/503/504 × {default, submitMaySettle:false}
  • Rail parity: image/music/video each hand the helper the right submitTimeoutMs / submitMaySettle
  • 5 of the new tests fail against 0.52.2 source, all pass with the fix
  • Full suite: 1327 pass, 0 fail; typecheck + build clean

Merging bumps to 0.52.3 and triggers publish.yml.

🤖 Generated with Claude Code

VickyXAI and others added 2 commits September 29, 2026 20:57
…video edge 5xx

The 0.52.2 image fix moved the Solana image rail onto solanaPaidAsyncPost
but kept its 30s submit default, which is sized for video's 3-20s enqueue.
The image route holds the paid POST for up to ~30s and answers 202 + poll_url
at the window's end, so the client aborted exactly when the job id was due —
after the transfer settled. It now passes SOLANA_IMAGE_SUBMIT_TIMEOUT_MS
(95s, the account rail's submit timeout for the same window).

The same release left the tracker armed on every edge 502/503/504 at the
submit. Right for image and music, which settle at POST; wrong for video,
which settles on the completed poll and so booked a phantom charge. Callers
now declare submitMaySettle (default true, the conservative side); video
passes false.

Both pinned by tests that fail on 0.52.2: the helper's edge-5xx behaviour
under each setting, and the per-route knobs each tool hands the helper.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@VickyXAI
VickyXAI merged commit e872360 into main Sep 29, 2026
3 checks passed
@VickyXAI
VickyXAI deleted the fix/solana-submit-timeouts branch September 29, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant