fix(solana): image submit timeout + no phantom booking on video edge 5xx (0.52.3) - #160
Merged
Merged
Conversation
…video edge 5xx The 0.52.2 image fix moved the Solana image rail onto solanaPaidAsyncPost but kept its 30s submit default, which is sized for video's 3-20s enqueue. The image route holds the paid POST for up to ~30s and answers 202 + poll_url at the window's end, so the client aborted exactly when the job id was due — after the transfer settled. It now passes SOLANA_IMAGE_SUBMIT_TIMEOUT_MS (95s, the account rail's submit timeout for the same window). The same release left the tracker armed on every edge 502/503/504 at the submit. Right for image and music, which settle at POST; wrong for video, which settles on the completed poll and so booked a phantom charge. Callers now declare submitMaySettle (default true, the conservative side); video passes false. Both pinned by tests that fail on 0.52.2: the helper's edge-5xx behaviour under each setting, and the per-route knobs each tool hands the helper. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for two defects in 0.52.2 (#159), found by the code review of #155.
1. The Solana image fix cut the paid submit off at 30s
#159 moved the Solana image rail onto
solanaPaidAsyncPostbut kept its 30s submit default (sized for video's 3–20s enqueue). The image route holds the paid POST up to ~30s and answers202 + poll_urlat the window's end — so the client aborted exactly when the job id was due, after the transfer settled. The fix never reached its target case, and renders finishing inline just past 30s (which 0.52.1 delivered) were lost too. NowSOLANA_IMAGE_SUBMIT_TIMEOUT_MS = 95_000, matching the account rail's submit timeout for the same window.2. Edge 5xx on a Solana video submit booked a phantom charge
#159 left the tracker armed on any 502/503/504 at submit. Correct for image/music (settle at POST); wrong for video (settles on the completed poll). New option
submitMaySettle(defaulttrue, conservative); video passesfalse.Tests
submitMaySettle:false}submitTimeoutMs/submitMaySettleMerging bumps to 0.52.3 and triggers
publish.yml.🤖 Generated with Claude Code